Fix payload queue and damp regression

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Netmonitor
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: rickychien, Assigned: rickychien)

Tracking

(Depends on: 3 bugs)

52 Branch
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
Bug 1362678 caused by bug 1344160 (netmonitor-controller refactoring). The key perf impact of queuing NetworkEventUpdate (bug 1358715) was accidentally ignored in bug 1344160.

I believe this would be the major key factor that `netmonitor.requestsFinished.DAMP` performs incredibly slow in talos test result https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=autoland&originalRevision=86de1de2f3f39bc225985f182ab992c97648f8a1&newProject=autoland&newRevision=a9339d769d2b03f5a21b8e7a804a0d2d528af1af&originalSignature=36adf201cb660409c00544b0a576c6f86c3eb669&newSignature=36adf201cb660409c00544b0a576c6f86c3eb669&framework=1
Comment hidden (mozreview-request)
(Assignee)

Comment 2

7 months ago
I'll add pushPayloadToQueue back and see what talos test says.

Comment 3

7 months ago
mozreview-review
Comment on attachment 8868629 [details]
Bug 1365635 - Fix payload queue and damp regression

https://reviewboard.mozilla.org/r/140216/#review143878

Ok, let's see if this helps.

Honza
Attachment #8868629 - Flags: review?(odvarko) → review+

Comment 4

7 months ago
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb83c677f01a
Fix payload queue and damp regression r=Honza

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cb83c677f01a
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Depends on: 1366083
Depends on: 1366296
Depends on: 1366153
You need to log in before you can comment on or make changes to this bug.