1365647 - Ensure that the height of panel views does not shrink smaller that of the main view

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[Mike de Boer [:mikedeboer]]

To control the height of each panel sub view, we can simply set the min-height CSS property for each panel individually to match the height of the main view.

Once the panel is opened for the first time, the main view is shown. From that point forward, it will never change its minimum allowed height for the subviews.

Comment 1

[:Gijs (he/him)]

(In reply to Mike de Boer [:mikedeboer] from comment #0)
> To control the height of each panel sub view, we can simply set the
> min-height CSS property for each panel individually to match the height of
> the main view.
> 
> Once the panel is opened for the first time, the main view is shown. From
> that point forward, it will never change its minimum allowed height for the
> subviews.

What happens with banner notifications at the top that get shown later?

Feels like we might need to clear the min-height onpopuphidden and re-set it onpopupshown.

Comment 2

[Mike de Boer [:mikedeboer]]

Good idea!

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1365647 - Make sure that the panel height never shrinks below the height of the main view in panelviews, like the main menu.

Review commit: https://reviewboard.mozilla.org/r/141560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141560/

Comment 4

[:Gijs (he/him)]

Comment on attachment 8870060 [details]
Bug 1365647 - Make sure that the panel height never shrinks below the height of the main view in panelviews, like the main menu.

https://reviewboard.mozilla.org/r/141560/#review145278

Haven't tested this, but code-wise it looks great. Thanks!

::: commit-message-9723d:1
(Diff revision 1)
> +Bug 1365647 - Make sure that the panel height never shrinks below the width of the main view in panelviews, like the main menu. r?Gijs

s/width/height/ :-)

::: browser/components/customizableui/PanelMultiView.jsm:566
(Diff revision 1)
>            let listener;
> -          let seen = 0;
>            this._viewContainer.addEventListener("transitionend", listener = ev => {
> -            if (ev.target == this._viewContainer && ev.propertyName == "height") {
> +            // It's quite common that `height` on the view container doesn't need
> +            // to transition, so we make sure to do all the work on the transform
> +            // transition, because that is ensure to happen.

Spelling nit: 'sure' or 'guaranteed'.

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8870060 [details]
Bug 1365647 - Make sure that the panel height never shrinks below the height of the main view in panelviews, like the main menu.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141560/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69c77ef0e94d
Make sure that the panel height never shrinks below the height of the main view in panelviews, like the main menu. r=Gijs

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/69c77ef0e94d

Comment 8

[u554753]

Hi Gijs, 

Any suggested/recommended STR to be able to verify this? Thanks!

Comment 9

[:Gijs (he/him)]

(In reply to Grover Wimberly IV [:Grover-QA] from comment #8)
> Hi Gijs, 
> 
> Any suggested/recommended STR to be able to verify this? Thanks!

Hi Grover,

With the photon pref enabled:
1) open the hamburger / main panel/menu
2) open the different items that open slide-in subviews ("More", "More > Character encoding", "Web Developer", ...)
3) check that the height of the panel can increase where necessary, but doesn't decrease (ie the panel doesn't get smaller after it's initially been opened)

Comment 10

[u554753]

Verified on Windows, Mac, and Ubuntu.