1365749 - Increase the amount of BHR data we collect back to pre bug 1364243 levels

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nika Layzell [:nika] (ni? for response)]

I asked for someone from telemetry in bug 1364243 comment 6 to investigate whether or not there was a dropoff in telemetry ping submissions after the patch to increase rate dropped on the 2nd. Ben Miroglio was awesome, and did some checks and it appears as though there was no significant increase in telemtry ping sizes at the 95th percentile, so I'm reverting our changes from bug 1364243 to restore the level of data which we have.

In addition, I confirmed that we have room to collect more data, so I am also increasing the stack depth which we are collecting for native hangs to 150, so that we collect more information. This should help with getting better data for bug 1344003.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bump kMaximumNativeHangStacks back to 300, and increase the number of native frames we are collecting

MozReview-Commit-ID: FahsOqeXeLL

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8868753 [details] [diff] [review]
Bump kMaximumNativeHangStacks back to 300, and increase the number of native frames we are collecting

Review of attachment 8868753 [details] [diff] [review]:
-----------------------------------------------------------------

r+ in person

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a7ad731e1e9
Bump kMaximumNativeHangStacks back to 300, and increase the number of native frames we are collecting, r=ehsan

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a7ad731e1e9

Comment 5

[Nika Layzell [:nika] (ni? for response)]

I forgot to link the gist which Ben sent me: https://gist.github.com/benmiroglio/39eb20e92a6fb0ad8055284009b2cd0c