Increase the amount of BHR data we collect back to pre bug 1364243 levels

RESOLVED FIXED in Firefox 55

Status

()

Core
XPCOM
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: mystor, Assigned: mystor)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

I asked for someone from telemetry in bug 1364243 comment 6 to investigate whether or not there was a dropoff in telemetry ping submissions after the patch to increase rate dropped on the 2nd. Ben Miroglio was awesome, and did some checks and it appears as though there was no significant increase in telemtry ping sizes at the 95th percentile, so I'm reverting our changes from bug 1364243 to restore the level of data which we have.

In addition, I confirmed that we have room to collect more data, so I am also increasing the stack depth which we are collecting for native hangs to 150, so that we collect more information. This should help with getting better data for bug 1344003.
Created attachment 8868753 [details] [diff] [review]
Bump kMaximumNativeHangStacks back to 300, and increase the number of native frames we are collecting

MozReview-Commit-ID: FahsOqeXeLL
Attachment #8868753 - Flags: review?(ehsan)
Comment on attachment 8868753 [details] [diff] [review]
Bump kMaximumNativeHangStacks back to 300, and increase the number of native frames we are collecting

Review of attachment 8868753 [details] [diff] [review]:
-----------------------------------------------------------------

r+ in person
Attachment #8868753 - Flags: review?(ehsan) → review+

Comment 3

3 months ago
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a7ad731e1e9
Bump kMaximumNativeHangStacks back to 300, and increase the number of native frames we are collecting, r=ehsan

Comment 4

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0a7ad731e1e9
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
I forgot to link the gist which Ben sent me: https://gist.github.com/benmiroglio/39eb20e92a6fb0ad8055284009b2cd0c
You need to log in before you can comment on or make changes to this bug.