Closed Bug 1365760 Opened 3 years ago Closed 3 years ago

Fix two tiny issues in mozJSComponentLoader::ImportInto()

Categories

(Core :: XPConnect, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

No description provided.
There's a second change to fix some leading whitespace. I don't know why it doesn't show up in mozreview.
-           JS_MarkCrossZoneId(cx, symbolId);
+            JS_MarkCrossZoneId(cx, symbolId);
Comment on attachment 8869115 [details]
Bug 1365760 - Fix two tiny issues in mozJSComponentLoader::ImportInto().

https://reviewboard.mozilla.org/r/140748/#review144220
Attachment #8869115 - Flags: review?(kmaglione+bmo) → review+
(In reply to Andrew McCreight [:mccr8] from comment #3)
> There's a second change to fix some leading whitespace. I don't know why it
> doesn't show up in mozreview.
> -           JS_MarkCrossZoneId(cx, symbolId);
> +            JS_MarkCrossZoneId(cx, symbolId);

Seems like a bug... It normally tries to mark whitespace-only changes, but there's apparently a toggle to hide them entirely. But flipping it doesn't seem to have any effect.
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bcb8a85c4663
Fix two tiny issues in mozJSComponentLoader::ImportInto(). r=kmag
https://hg.mozilla.org/mozilla-central/rev/bcb8a85c4663
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.