Fix two tiny issues in mozJSComponentLoader::ImportInto()

RESOLVED FIXED in Firefox 55

Status

()

Core
XPConnect
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 months ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=92966d66cffc4ab7faeef64d2f6a279179a1de8b
Comment hidden (mozreview-request)
(Assignee)

Comment 3

5 months ago
There's a second change to fix some leading whitespace. I don't know why it doesn't show up in mozreview.
-           JS_MarkCrossZoneId(cx, symbolId);
+            JS_MarkCrossZoneId(cx, symbolId);
Comment on attachment 8869115 [details]
Bug 1365760 - Fix two tiny issues in mozJSComponentLoader::ImportInto().

https://reviewboard.mozilla.org/r/140748/#review144220
Attachment #8869115 - Flags: review?(kmaglione+bmo) → review+
(In reply to Andrew McCreight [:mccr8] from comment #3)
> There's a second change to fix some leading whitespace. I don't know why it
> doesn't show up in mozreview.
> -           JS_MarkCrossZoneId(cx, symbolId);
> +            JS_MarkCrossZoneId(cx, symbolId);

Seems like a bug... It normally tries to mark whitespace-only changes, but there's apparently a toggle to hide them entirely. But flipping it doesn't seem to have any effect.

Comment 6

5 months ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bcb8a85c4663
Fix two tiny issues in mozJSComponentLoader::ImportInto(). r=kmag

Comment 7

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bcb8a85c4663
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.