1365763 - Trigger spidermonkey builds in more cases

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Yesterday, bug 1365194 burned the tree well after landing because
a) the failing sm builds never happened on try
b) the failing sm builds didn't happen on autoland
c) the failing sm builds only happened after autoland was merged to mozilla-central, presumably because something that landed before bug 1365194 touched js/

Enough is enough.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1365763 - Make all spidermonkey tasks depend on more file changes.

I've been bitten by spidermonkey tasks not running on automation enough.
Anything that can have an influence on spidermonkey builds should
trigger them to build, not only js/ changes.

As it turns out, the sm-package task has a more complete list of things
spidermonkey depends on, so we just use that same list for all tasks.

Review commit: https://reviewboard.mozilla.org/r/140364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140364/

Comment 2

[Mike Hommey [:glandium]]

Funnily enough, the builds that failed are not even tc builds... they're buildbot builds, so this patch wouldn't have changed the outcome for bug 1365194...

Comment 3

[Mike Hommey [:glandium]]

How do we make the same change for buildbot?

Comment 4

[Mike Hommey [:glandium]]

nthomas helped figure this out on irc.

Comment 5

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8868764 [details]
Bug 1365763 - Make all spidermonkey tasks depend on more file changes.

https://reviewboard.mozilla.org/r/140364/#review143676

Sorry, I had this done in bug 1325936 but got stalled off trying to implement one of your review suggestions there (removing some of the dependencies) and never landed. That was dumb.

I'll mark this r+ and dupe my bug to this. Removing dependencies can happen later.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36a35446bb72
Make all spidermonkey tasks depend on more file changes. r=sfink

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1365763 - Use the same list as TC to trigger SM builds.

Review commit: https://reviewboard.mozilla.org/r/140376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140376/

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8868787 [details]
Bug 1365763 - Use the same list as TC to trigger SM builds.

https://reviewboard.mozilla.org/r/140376/#review143702

Seems fine to me.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8868787 [details]
Bug 1365763 - Use the same list as TC to trigger SM builds.

https://hg.mozilla.org/build/buildbotcustom/rev/7e52a02ef63c22380fb4e01afc5333a6658a3371
https://hg.mozilla.org/build/buildbotcustom/rev/2fbc640ac74c3e96f020118b01e7ab0d76b21d77

Will be deployed in a few minutes.

Comment 11

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/36a35446bb72