1365786 - specifying option(..., default=...) can not pass the linter for obscure reasons

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

I have the following code in a moz.configure file:

@depends(milestone, target)
def stylo_default(milestone, target):
    # bindgen + C++ doesn't work on win32 at the moment.
    if target.os == 'WINNT' and target.bitness == 32:
        return False

    # The clang setup we use is a little unusual, and doesn't play well
    # with bindgen on 32-bit Linux.
    if target.os == 'GNU' and target.bitness == 32:
        return False

    # Stylo on Android is happening Later(tm).
    if target.os == 'Android':
        return False

    return milestone.is_nightly

option('--enable-stylo', env='STYLO_ENABLED',
       help='Enables build-time support for the servo style system.',
       default=stylo_default)

and the linter complains:

ConfigureError: Missing @depends for `stylo_default`: '--help'

We pass --help for @depends to other such default functions in some places...and some places we don't.  glandium claims this is expected, but that the above snippet should work.  glandium, do you think you can fix this?

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1365786 - Avoid missing --help dep error when a @depends function uses builtins.

Review commit: https://reviewboard.mozilla.org/r/140402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140402/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8868796 [details]
Bug 1365786 - Avoid missing --help dep error when a @depends function uses builtins.

https://reviewboard.mozilla.org/r/140402/#review144308

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b602649e673
Avoid missing --help dep error when a @depends function uses builtins. r=chmanchester

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b602649e673