Closed
Bug 1365793
Opened 8 years ago
Closed 8 years ago
JSONParser::readString() is slower than it needs to be on Windows because of isxdigit()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
1.46 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
I found this when looking into bug 1363335. Apparently isxdigit() on Windows is super slow, and that makes JSONParser::readString() slower than it needs to be. See this profile: https://perfht.ml/2rgyW5t
Naveed, can you please find an owner for this?
Flags: needinfo?(nihsanullah)
Assignee | ||
Updated•8 years ago
|
Blocks: SearchFirstResult_YouTube
Assignee | ||
Comment 1•8 years ago
|
||
See bug 339868. Looks like we've known about this for a while!
See Also: → 339868
Assignee | ||
Comment 2•8 years ago
|
||
I should be able to do this myself. :-)
Assignee: nobody → ehsan
Flags: needinfo?(nihsanullah)
Assignee | ||
Comment 3•8 years ago
|
||
Not sure who to ask for review here. Asking Luke since he originally added the file.
Attachment #8868833 -
Flags: review?(luke)
![]() |
||
Comment 4•8 years ago
|
||
Comment on attachment 8868833 [details] [diff] [review]
Inline isxdigit() manually in the JS engine
Review of attachment 8868833 [details] [diff] [review]:
-----------------------------------------------------------------
Great!
Attachment #8868833 -
Flags: review?(luke) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15179fb5cc42
Inline isxdigit() manually in the JS engine; r=luke
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•3 years ago
|
Performance Impact: --- → P1
Whiteboard: [qf:p1]
You need to log in
before you can comment on or make changes to this bug.
Description
•