Closed Bug 1365793 Opened 8 years ago Closed 8 years ago

JSONParser::readString() is slower than it needs to be on Windows because of isxdigit()

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Performance Impact high
Tracking Status
firefox55 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

I found this when looking into bug 1363335. Apparently isxdigit() on Windows is super slow, and that makes JSONParser::readString() slower than it needs to be. See this profile: https://perfht.ml/2rgyW5t Naveed, can you please find an owner for this?
Flags: needinfo?(nihsanullah)
See bug 339868. Looks like we've known about this for a while!
See Also: → 339868
I should be able to do this myself. :-)
Assignee: nobody → ehsan
Flags: needinfo?(nihsanullah)
Not sure who to ask for review here. Asking Luke since he originally added the file.
Attachment #8868833 - Flags: review?(luke)
Comment on attachment 8868833 [details] [diff] [review] Inline isxdigit() manually in the JS engine Review of attachment 8868833 [details] [diff] [review]: ----------------------------------------------------------------- Great!
Attachment #8868833 - Flags: review?(luke) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/15179fb5cc42 Inline isxdigit() manually in the JS engine; r=luke
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Performance Impact: --- → P1
Whiteboard: [qf:p1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: