1365836 - Inline nsContentUtils::InternalContentPolicyTypeToExternal(OrPreload)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[(no longer active)]

I've seen nsContentUtils::InternalContentPolicyTypeToExternal() come up in profiles a bunch of times, it's called from many important places and there is no reason for it to not be inlined.

Comment 1

[(no longer active)]

Attachment: Inline nsContentUtils::InternalContentPolicyTypeToExternal(OrPreload)

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8868868 [details] [diff] [review]
Inline nsContentUtils::InternalContentPolicyTypeToExternal(OrPreload)

Review of attachment 8868868 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentUtils.h
@@ +1156,5 @@
>  
>    /**
>     * Map internal content policy types to external ones.
>     */
> +  static inline nsContentPolicyType InternalContentPolicyTypeToExternal(nsContentPolicyType aType);

This seems like an overly long line, perhaps wrap it after the return type?

@@ +1166,5 @@
>     *   * TYPE_INTERNAL_STYLESHEET_PRELOAD
>     *
>     * Note: DO NOT call this function unless you know what you're doing!
>     */
> +  static inline nsContentPolicyType InternalContentPolicyTypeToExternalOrPreload(nsContentPolicyType aType);

Same.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3826b6da14a9
Inline nsContentUtils::InternalContentPolicyTypeToExternal(OrPreload); r=mystor

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3826b6da14a9