Inline nsContentUtils::InternalContentPolicyTypeToExternal(OrPreload)

RESOLVED FIXED in Firefox 55

Status

()

Core
DOM
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I've seen nsContentUtils::InternalContentPolicyTypeToExternal() come up in profiles a bunch of times, it's called from many important places and there is no reason for it to not be inlined.
(Assignee)

Comment 1

a year ago
Created attachment 8868868 [details] [diff] [review]
Inline nsContentUtils::InternalContentPolicyTypeToExternal(OrPreload)
Attachment #8868868 - Flags: review?(michael)

Comment 2

a year ago
Comment on attachment 8868868 [details] [diff] [review]
Inline nsContentUtils::InternalContentPolicyTypeToExternal(OrPreload)

Review of attachment 8868868 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentUtils.h
@@ +1156,5 @@
>  
>    /**
>     * Map internal content policy types to external ones.
>     */
> +  static inline nsContentPolicyType InternalContentPolicyTypeToExternal(nsContentPolicyType aType);

This seems like an overly long line, perhaps wrap it after the return type?

@@ +1166,5 @@
>     *   * TYPE_INTERNAL_STYLESHEET_PRELOAD
>     *
>     * Note: DO NOT call this function unless you know what you're doing!
>     */
> +  static inline nsContentPolicyType InternalContentPolicyTypeToExternalOrPreload(nsContentPolicyType aType);

Same.
Attachment #8868868 - Flags: review?(michael) → review+

Comment 3

a year ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3826b6da14a9
Inline nsContentUtils::InternalContentPolicyTypeToExternal(OrPreload); r=mystor
Assignee: nobody → ehsan

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3826b6da14a9
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.