stylo: Trigger an animation-only restyle when we handle an event with coordinates for SMIL

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P4
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: boris, Assigned: birtles)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
In bug 1334036, we flush throttled animations when we handle an event with coordinates [1] for CSS animations/transitions, but didn't implement it for SMIL.

[1] http://searchfox.org/mozilla-central/rev/f55349994fdac101d121b11dac769f3f17fbec4b/layout/base/PresShell.cpp#7374
We do need this?  I think we don't run any SMIL animations on the compositor for now.
Assignee

Comment 2

2 years ago
No, but we throttle SMIL animations in other situations (e.g. invisible animations, perhaps offscreen animations too, I'm not sure). I'm not that any of those could actually effect events, however.
Priority: P3 → --
Assignee

Comment 3

2 years ago
I'm not aware of any case where this actually makes a difference, so P4 for now.
Priority: -- → P4
Assignee

Comment 4

2 years ago
I can't think of any case where we throttle SMIL animations that could affect events. I'm just going to drop the comment for this and then close this.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8905391 [details]
Bug 1365855 - Drop comment about needing to update SMIL animation styles in ServoRestyleManager::UpdateOnlyAnimationStyles;

https://reviewboard.mozilla.org/r/177174/#review182220
Attachment #8905391 - Flags: review?(hikezoe) → review+

Comment 8

2 years ago
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bb39688625c
Drop comment about needing to update SMIL animation styles in ServoRestyleManager::UpdateOnlyAnimationStyles; r=hiro; DONTBUILD
Assignee

Comment 9

2 years ago
Pushed to m-i because mozreview/autoland seems to strip DONTBUILD from the commit message.
https://hg.mozilla.org/mozilla-central/rev/2bb39688625c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.