1365855 - stylo: Trigger an animation-only restyle when we handle an event with coordinates for SMIL

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Boris Chiou [:boris]]

In bug 1334036, we flush throttled animations when we handle an event with coordinates [1] for CSS animations/transitions, but didn't implement it for SMIL.

[1] http://searchfox.org/mozilla-central/rev/f55349994fdac101d121b11dac769f3f17fbec4b/layout/base/PresShell.cpp#7374

Comment 1

[Hiroyuki Ikezoe (:hiro)]

We do need this?  I think we don't run any SMIL animations on the compositor for now.

Comment 2

[Brian Birtles (:birtles)]

No, but we throttle SMIL animations in other situations (e.g. invisible animations, perhaps offscreen animations too, I'm not sure). I'm not that any of those could actually effect events, however.

Comment 3

[Brian Birtles (:birtles)]

I'm not aware of any case where this actually makes a difference, so P4 for now.

Comment 4

[Brian Birtles (:birtles)]

I can't think of any case where we throttle SMIL animations that could affect events. I'm just going to drop the comment for this and then close this.

Comment 5

[Brian Birtles (:birtles)]

Attachment: Bug 1365855 - Drop comment about needing to update SMIL animation styles in ServoRestyleManager::UpdateOnlyAnimationStyles;

Unlike GeckoRestyleManager::UpdateOnlyAnimationStyles which is called from
*both* GeckoRestyleManager::ProcessPendingRestyles and FlushThrottledStyles,
ServoRestyleManager::UpdateOnlyAnimationStyles is only called from
FlushThrottledStyles which is what we use to update transform animations before
doing hit-testing. In this case, there doesn't appear to be any situation where
throttled SMIL animations need to be updated since SMIL animations are only
throttled when they apply to display:none content (bug 1209405 and bug 1322970)
in which case they should not affect hit testing.

Review commit: https://reviewboard.mozilla.org/r/177174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177174/

Comment 6

[Brian Birtles (:birtles)]

Comment on attachment 8905391 [details]
Bug 1365855 - Drop comment about needing to update SMIL animation styles in ServoRestyleManager::UpdateOnlyAnimationStyles;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177174/diff/1-2/

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8905391 [details]
Bug 1365855 - Drop comment about needing to update SMIL animation styles in ServoRestyleManager::UpdateOnlyAnimationStyles;

https://reviewboard.mozilla.org/r/177174/#review182220

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bb39688625c
Drop comment about needing to update SMIL animation styles in ServoRestyleManager::UpdateOnlyAnimationStyles; r=hiro; DONTBUILD

Comment 9

[Brian Birtles (:birtles)]

Pushed to m-i because mozreview/autoland seems to strip DONTBUILD from the commit message.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2bb39688625c