Closed Bug 1365855 Opened 3 years ago Closed 3 years ago

stylo: Trigger an animation-only restyle when we handle an event with coordinates for SMIL

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: boris, Assigned: birtles)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 1334036, we flush throttled animations when we handle an event with coordinates [1] for CSS animations/transitions, but didn't implement it for SMIL.

[1] http://searchfox.org/mozilla-central/rev/f55349994fdac101d121b11dac769f3f17fbec4b/layout/base/PresShell.cpp#7374
We do need this?  I think we don't run any SMIL animations on the compositor for now.
No, but we throttle SMIL animations in other situations (e.g. invisible animations, perhaps offscreen animations too, I'm not sure). I'm not that any of those could actually effect events, however.
Priority: P3 → --
I'm not aware of any case where this actually makes a difference, so P4 for now.
Priority: -- → P4
I can't think of any case where we throttle SMIL animations that could affect events. I'm just going to drop the comment for this and then close this.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Comment on attachment 8905391 [details]
Bug 1365855 - Drop comment about needing to update SMIL animation styles in ServoRestyleManager::UpdateOnlyAnimationStyles;

https://reviewboard.mozilla.org/r/177174/#review182220
Attachment #8905391 - Flags: review?(hikezoe) → review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bb39688625c
Drop comment about needing to update SMIL animation styles in ServoRestyleManager::UpdateOnlyAnimationStyles; r=hiro; DONTBUILD
Pushed to m-i because mozreview/autoland seems to strip DONTBUILD from the commit message.
https://hg.mozilla.org/mozilla-central/rev/2bb39688625c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.