1365906 - Location bar and search bar text sizes are too small on Windows

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Comment 1

[Dale Harvey (:daleharvey)]

My mistake, I put the existing font-size inside a photon ifdef

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: 1365906-1.patch

We want 1.15em in photon, thats what it was originally so I left it alone and ifdef'd around it, but this was already inside a larger ifdef that I missed, so duplicated the font-size so it applies to photon as well

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8868989 [details] [diff] [review]
1365906-1.patch

>+@media (-moz-os-version: windows-win10) {
>+  #urlbar,
>+  .searchbar-textbox {
>+    font-size: 1.15em;
>+  }
>+}

I think we want this regardless of the Windows version.

Comment 4

[Dale Harvey (:daleharvey)]

Attachment: 1365906-2.patch

Yeh I was thinking about setting it on all platforms, just being a little conservative using the current rules, cheers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/57b76ce88152
Increase URL bar and the search bar text size for all Windows versions. r=dao

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/57b76ce88152

Comment 7

[u595641]

(In reply to Dale Harvey (:daleharvey) from comment #4)
> Created attachment 8868999 [details] [diff] [review]
> 1365906-2.patch
> 
> Yeh I was thinking about setting it on all platforms, just being a little
> conservative using the current rules, cheers

I like the small font :(

and pref to get it back? please :(

Comment 8

[u595641]

Please provide an in built option to revert back to small fonts,
why do compact themes have vertical padding so much?
where to file bug to remove it or is it intentional in which case it's eating up Precious space for content :(

Comment 9

[Dão Gottwald [:dao]]

(In reply to Sami from comment #7)
> and pref to get it back? please :(

We're not going to add a pref for this.

(In reply to Sami from comment #8)
> Please provide an in built option to revert back to small fonts,
> why do compact themes have vertical padding so much?
> where to file bug to remove it or is it intentional in which case it's
> eating up Precious space for content :(

See bug 1350210 for compact mode support.

Comment 10

[Sajedul Islam]

I have reproduced this bug with Nightly 55.0a1 (2017-05-18) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest Nightly 55.0a1 !

Build ID      20170519030205
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday-20170519]

Comment 11

[Dão Gottwald [:dao]]

(In reply to Sajedul Islam from comment #10)
> I have reproduced this bug with Nightly 55.0a1 (2017-05-18) on Windows 8.1 ,
> 64 Bit ! 
> 
> This bug's fix is Verified with latest Nightly 55.0a1 !

Thanks.

(In reply to Dão Gottwald [::dao] from comment #9)
> (In reply to Sami from comment #8)
> > Please provide an in built option to revert back to small fonts,
> > why do compact themes have vertical padding so much?
> > where to file bug to remove it or is it intentional in which case it's
> > eating up Precious space for content :(
> 
> See bug 1350210 for compact mode support.

I've filed bug 1366346 specifically for the location / search bar text size.

Comment 12

[Johann Hofmann [:johannh]]

Screenshots here:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=3801e9bd76ad91b5754faacd3fec9ad4bc3fc782&newProject=mozilla-central&newRev=183c3537157290d7ccef475651b6bc35db914924

along with the changes from bug 1365683.