Closed Bug 1365940 Opened 2 years ago Closed 2 years ago

struct WindowAction in WorkerPrivate.cpp should be marked MOZ_RAII

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

This helps to understand why we have a raw pointer for mWindow and why that is OK.
Attached patch raii.patchSplinter Review
Assignee: nobody → amarchesini
Attachment #8869027 - Flags: review?(kyle)
Attachment #8869027 - Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a6693755c7d
struct WindowAction in WorkerPrivate.cpp should be marked MOZ_RAII, r=qdot
Backed out for bustage at nsTArray.h:568:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e48946fd355251d61767f7ec6dd4a712bc36d9d

Push with failures (the win32 bustage is something different): https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3a6693755c7d248bf40d6cf5caea365677da12ed&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=100225336&repo=mozilla-inbound

[task 2017-05-18T21:17:48.478612Z] 21:17:48     INFO -  In file included from /home/worker/workspace/build/src/dom/workers/WorkerLocation.cpp:7:
[task 2017-05-18T21:17:48.478842Z] 21:17:48     INFO -  In file included from /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/WorkerLocation.h:10:
[task 2017-05-18T21:17:48.479018Z] 21:17:48     INFO -  In file included from /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/workers/Workers.h:18:
[task 2017-05-18T21:17:48.479354Z] 21:17:48     INFO -  /home/worker/workspace/build/src/obj-firefox/dist/include/nsTArray.h:568:62: error: variable of type '(anonymous namespace)::WindowAction' is not valid in a temporary
[task 2017-05-18T21:17:48.479528Z] 21:17:48     INFO -    bool Equals(const A& aA, const B& aB) const { return aA == aB; }
[task 2017-05-18T21:17:48.479735Z] 21:17:48     INFO -                                                               ^
Flags: needinfo?(amarchesini)
Unfortunately, this cannot be done.
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(amarchesini)
Resolution: --- → FIXED
Resolution: FIXED → INVALID
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.