Closed Bug 1365961 Opened 3 years ago Closed 3 years ago

Sidebar context menu missing container icons

Categories

(WebExtensions :: Frontend, enhancement, P2)

54 Branch
enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jkt, Assigned: mixedpuppy)

Details

(Whiteboard: [sidebar][triaged])

Attachments

(2 files)

Attached image Selection_629.png
When an <a> tag is used in a sidebar the container icons are missing when the user uses a context menu.

Example addon:
https://addons.mozilla.org/en-US/firefox/addon/sea-containers/

See attachment for screenshot.
need infoing shane to prioritize since SideBar issue(after monday holiday).  If Shane wants to discuss with team, remove needinfo and we'll discuss at next triage.
Flags: needinfo?(mixedpuppy)
Whiteboard: [sidebar]
This is just a case of missing css.
Assignee: nobody → mixedpuppy
Flags: needinfo?(mixedpuppy)
Should have checked that, thanks! (I didn't know that file existed)
Comment on attachment 8870512 [details]
Bug 1365961 include containers css for sidebars,

https://reviewboard.mozilla.org/r/141942/#review146070
Attachment #8870512 - Flags: review?(aswan) → review+
Priority: -- → P2
Whiteboard: [sidebar] → [sidebar][triaged]
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0344daf0fe0c
include containers css for sidebars, r=aswan
https://hg.mozilla.org/mozilla-central/rev/0344daf0fe0c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.