1365998 - Officially ship the streamlined stub installer

Status: VERIFIED FIXED

(Firefox :: Installer, enhancement, P2)

Description

[Molly Howell (she/her) (mostly inactive)]

The decision has been made to ship the sreamlined stub installer of bug 1328445 as amended for bug 1353576, following successful funnelcake testing of the onboarding 2.0 project which includes it. This bug will track that process.

The first step is to get those patches rebased and pushed to central, so we start getting nightly builds on which QA and L10N can begin.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

We're getting ready to land the streamlined stub installer for real, which means I need versions of attachment 8824555 [details] from bug 1328445 for the other channels. Verdi, would you be able to supply those?

Comment 2

[Verdi [:verdi] Best to slack me]

Attachment: Firefox-1X-final-stub-background.png

New background for beta and release (better colors than previous one).

Comment 3

[Verdi [:verdi] Best to slack me]

Attachment: DevEdition-1X-final-stub-background.png

Comment 4

[Verdi [:verdi] Best to slack me]

Attachment: Nightly-1X-final-stub-background.png

Comment 5

[Verdi [:verdi] Best to slack me]

Attachment: Firefox-2X-final-stub-background.png

Comment 6

[Verdi [:verdi] Best to slack me]

Attachment: Dev-Edition-2X-final-stub-background.png

Comment 7

[Verdi [:verdi] Best to slack me]

Attachment: Nightly-2X-final-stub-background.png

Comment 8

[Molly Howell (she/her) (mostly inactive)]

So unfortunately I don't really have a way to use both the 1x and the 2x images and select the correct one at runtime right now, and if I just use the 2x one it looks silky smooth on hi-DPI, but with a standard DPI it doesn't scale down well and the logo text gets kind of jagged. This is tearing me up because the 2x background with hi-res text on top of it is *so pretty*, but I think I'm going to have to use just the 1x images for now and let the hi-DPI case have the jaggies instead of the more common 100% scaling case. This is a problem that the current stub also has (it's bug 1361209). And speaking as a 4k monitor owner, we are pretty used to it.

Comment 9

[Molly Howell (she/her) (mostly inactive)]

Attachment: Part 1 - Images for streamlined stub installer

This patch is the same as attachment 8854975 [details] [diff] [review] except that I swapped out the background images for the ones attached here and created icon files for all branding directories (but not new icons; they're just the application icons in different sizes). Those icons should be temporary; newly-designed ones are expected soon.

Comment 10

[Molly Howell (she/her) (mostly inactive)]

Attachment: Part 2 - Streamlined stub installer

This patch is the same as attachment 8854993 [details] [diff] [review] except that I rebased it to current central (which already had one or two of the changes) and fixed one NSIS compiler warning about an unused function (ExecSetAsDefaultAppUser) by removing the function.

Comment 11

[Molly Howell (she/her) (mostly inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/535341e77a11e745a7c2ac2a824ec9ab53a7b026
Bug 1365998 Part 1 - Images for streamlined stub installer. r=mhowell

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2aaebf3c402a17b8a5645995edf42d718edeb03
Bug 1365998 Part 2 - Streamlined stub installer. r=mhowell

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/535341e77a11
https://hg.mozilla.org/mozilla-central/rev/e2aaebf3c402

Comment 13

[Francesco Lodolo [:flod]]

+WARN_WRITE_ACCESS_QUIT=You don't have access to write to the installation directory
+WARN_DISK_SPACE_QUIT=You don't have sufficient disk space to install.

Is there are a reason for only one of these two strings to end with a period?

Comment 14

[Molly Howell (she/her) (mostly inactive)]

WARN_WRITE_ACCESS_QUIT gets a second line appended to it with the path to the directory in question. WARN_DISK_SPACE_QUIT is shown by itself.

Comment 15

[Francesco Lodolo [:flod]]

(In reply to Matt Howell [:mhowell] from comment #14)
> WARN_WRITE_ACCESS_QUIT gets a second line appended to it with the path to
> the directory in question. WARN_DISK_SPACE_QUIT is shown by itself.

Thanks, that's reasonable then (also worth a localization comment).

Comment 16

[Molly Howell (she/her) (mostly inactive)]

Release Note Request (optional, but appreciated)
[Why is this notable]:
This is a complete redesign of the Windows default (stub) installer. Most notably, the options page has been removed, so users who need any of the installation options will need to go get a full installer instead. We should document that fact somewhere, and the release notes seem like a logical place.

[Affects Firefox for Android]:
No

[Suggested wording]:
"We've streamlined the default Windows installer. To change installation options, like the destination directory, download an offline installer from the All Downloads page."
(I don't remember what that page is actually called. Also that text should be a link to the page.)

[Links (documentation, blog post, etc)]:
https://www.mozilla.org/en-US/firefox/all/

Comment 17

[Julien Cristau [:jcristau]]

adding to the 55 release notes

Comment 18

[Abe - QA (:Abe_LV)]

Verified as fixed. 
This bug is verified by Grover.
Test runs are here:https://testrail.stage.mozaws.net/index.php?/runs/view/4419 
Needinfo me if you have feedback or questions.