Closed
Bug 1366006
Opened 7 years ago
Closed 7 years ago
Move Heartbeat CSS into add-on
Categories
(Firefox :: Normandy Client, enhancement)
Firefox
Normandy Client
Tracking
()
RESOLVED
INVALID
People
(Reporter: mythmon, Assigned: mythmon)
References
Details
Shield currently relies on the CSS provided by UITour for styling Heartbeat. That CSS is here: https://dxr.mozilla.org/mozilla-central/rev/85e5d15c31691c89b82d6068c26260416493071f/browser/themes/shared/UITour.inc.css and included in the browser here: https://dxr.mozilla.org/mozilla-central/rev/85e5d15c31691c89b82d6068c26260416493071f/browser/themes/linux/browser.css#1216
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mcooper
Assignee | ||
Comment 1•7 years ago
|
||
Actually, it doesn't make sense to do this separate from bug 1366005, since they can't land separately. Copying the CSS and SVG files needed to succeed here cause the duplicate file checker to fail, understandably, until bug 1366005 is done.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Comment 2•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/normandy https://github.com/mozilla/normandy/commit/568568d26823efb3439c6a7fdcaf0e0a536e971a Bug 1366006 - Move Heartbeat CSS into add-on. (#770) * Bug 1366006 - Move Heartbeat CSS into add-on. * recipe-client-addon: Fix lint errors in Heartbeat CSS * recipe-client-addon: Use correct url when unloading Heartbeat CSS on OSX. * Fix lint errors * recipe-client-addon: Copy Heartbeat SVGs from mozilla-central * Fix packaging error and path * Add !important to Hearbeat CSS rules.
Updated•6 years ago
|
Product: Shield → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•