1366021 - Do not use 'else' after 'return' in /js/src/frontend/Parser.cpp

Status: RESOLVED FIXED

Description

[Jan Keromnes [:janx]]

When running static analysis on /js/src/jit/x86-shared/Disassembler-x86-shared.cpp with the following command:

    $ run-clang-tidy-4.0.py -j 18 -p obj-x86_64-pc-linux-gnu/ -checks=-*,clang-analyzer-deadcode.DeadStores js/src/jit/x86-shared/

We get the following warning:

    /home/user/firefox/js/src/frontend/Parser.cpp:1495:11: warning: do not use 'else' after 'return' [readability-else-after-return]
            } else {
              ^

Comment 1

[Jan Keromnes [:janx]]

Created attachment 8869120 [details] [diff] [review]
Readability: Do not use 'else' after 'return' in /js/src/frontend/Parser.cpp.

Comment 2

[Benjamin Bouvier [:bbouvier]]

Comment on attachment 8869120 [details] [diff] [review]
Readability: Do not use 'else' after 'return' in /js/src/frontend/Parser.cpp.

Review of attachment 8869120 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Can you remove "readability" from the changeset message and make sure that try tests (jsreftests + jittests) pass, please?

Comment 3

[Jan Keromnes [:janx]]

Created attachment 8869734 [details] [diff] [review]
Do not use 'else' after 'return' in /js/src/frontend/Parser.cpp.

Updated commit message, rebased, r+ carried over, try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b53eb1bcf42

Comment 4

[Jan Keromnes [:janx]]

The assertion failures in /src/ld/ld.hpp on "OS X 10.7 opt" seem unrelated (see orange try jobs "cgc" and "p"). Please land this patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fa35ea59bdd
Do not use 'else' after 'return' in /js/src/frontend/Parser.cpp. r=bbouvier

Comment 6

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/8fa35ea59bdd

Comment 7

[Mike Conley (:mconley) (:⚙️) - Backlogged on reviews and needinfos]

https://hg.mozilla.org/projects/cedar/rev/8fa35ea59bdd416eadfec7def8e9c29222d908cc
Bug 1366021 - Do not use 'else' after 'return' in /js/src/frontend/Parser.cpp. r=bbouvier