make balrog submission tools support old id builds



2 years ago
2 years ago


(Reporter: bhearsum, Assigned: bhearsum)


Firefox Tracking Flags

(Not tracked)



(2 attachments)

Created attachment 8869138 [details] [diff] [review]
add old-id mappings + hack

Similar to the old api-9 builds, we're going to have two sets of builds on mozilla-central that both have the same build targets, but need separate balrog blobs. I'm pretty sure we don't do api-9 anywhere anymore, so it should be safe to override this.
Attachment #8869138 - Flags: review?(rail)
Blocks: 1357808


2 years ago
Attachment #8869138 - Flags: review?(rail) → review+
Comment on attachment 8869138 [details] [diff] [review]
add old-id mappings + hack

Landed with removal of api-9, and an updated comment:
Attachment #8869138 - Flags: checked-in+
Created attachment 8869437 [details] [diff] [review]
bump balrogclient version

Looks like updating the tools repo on the balrogworker machines causes them to fail to import ScheduledRuleChange, eg:
2017-05-18 21:47:39,748 - INFO - Servers: [u'nightly']
2017-05-18 21:47:39,751 - INFO - Reading manifest file /builds/scriptworker/work/cot/Yn-lX8dFTPWvB9kakJFb9Q/public/manifest.json
Traceback (most recent call last):
  File "/builds/scriptworker/py27venv/bin/balrogscript", line 9, in <module>
    load_entry_point('balrogscript==0.1.0', 'console_scripts', 'balrogscript')()
  File "/builds/scriptworker/py27venv/lib/python2.7/site-packages/balrogscript/", line 121, in main
    submitter, release = create_submitter(e, balrog_auth, config)
  File "/builds/scriptworker/py27venv/lib/python2.7/site-packages/balrogscript/", line 19, in create_submitter
    from balrog.submitter.cli import NightlySubmitterV4  # noqa: E402
  File "/builds/scriptworker/tools/lib/python/balrog/submitter/", line 12, in <module>
    from balrog.submitter.api import Release, SingleLocale, Rule, ScheduledRuleChange
  File "/builds/scriptworker/tools/lib/python/balrog/submitter/", line 6, in <module>
    from balrogclient import is_csrf_token_expired, SingleLocale, Release, Rule, ScheduledRuleChange
ImportError: cannot import name ScheduledRuleChange
exit code: 1

No surprise, since that's a fairly recent addition.
Attachment #8869437 - Flags: review?
Attachment #8869437 - Flags: review? → review+
Attachment #8869437 - Flags: checked-in+
Everything looks good here now with the new balrogclient in place.
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.