1366062 - source maps not reloaded by navigation

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Tom Tromey :tromey]

When navigating, the source map cache should be cleared.
Currently it is not, though.

Comment 1

[Tom Tromey :tromey]

There's a follow-up here, which is that the new debugger handles this clearing itself;
but when in the toolbox it really should not.
I am deferring this because I think there may be other reasons to move the source map URL service
into devtools-source-map, but that requires more research.

Comment 2

[Tom Tromey :tromey]

Attachment: Bug 1366062 - clear SourceMapURLService cache on navigation;

Review commit: https://reviewboard.mozilla.org/r/140806/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140806/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8869215 [details]
Bug 1366062 - clear SourceMapURLService cache on navigation;

https://reviewboard.mozilla.org/r/140806/#review144264

Makes sense to me, thanks for adding a test!

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8869215 [details]
Bug 1366062 - clear SourceMapURLService cache on navigation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140806/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44874c36cec7
clear SourceMapURLService cache on navigation; r=jryans

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/44874c36cec7