1366071 - Add check to talos tp6 to ensure mitmproxy certificate was installed

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Robert Wood [:rwood]]

Improve the talos mitmproxy support (Bug 1357382) by adding a check to verify that the mitmproxy CA certificate was installed into Firefox. The code to install the cert is implemented, but we need a check after because without the certificate mitdump playback won't work with Firefox.

/testing/talos/talos/run_tests.py:is_mitmproxy_cert_installed()

Comment 1

[Robert Wood [:rwood]]

Attachment: Bug 1366071 - Add check in talos tp6 to ensure mitmproxy certificate was installed successfully;

Review commit: https://reviewboard.mozilla.org/r/171294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171294/

Comment 2

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ba2876591e7a16686a9c7266d8d2b65c614a8d6

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8899968 [details]
Bug 1366071 - Add check in talos tp6 to ensure mitmproxy certificate was installed successfully;

https://reviewboard.mozilla.org/r/171294/#review176710

::: testing/talos/talos/mitmproxy/mitmproxy.py:84
(Diff revision 1)
> +        certificate = _read_certificate(DEFAULT_CERT_PATH)
> +        contents = read_autoconfig_file(browser_install)
> +        if (MITMPROXY_SETTINGS % {'cert': certificate}) in contents:
> +            LOG.info("Verified mitmproxy CA certificate is installed in Firefox")
> +        else:
> +            return False

should we add more info here to expand on the failure  so we don't have to guess what was in the contents?

Comment 4

[Robert Wood [:rwood]]

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #3)
> Comment on attachment 8899968 [details]
> Bug 1366071 - Add check in talos tp6 to ensure mitmproxy certificate was
> installed successfully;
> 
> https://reviewboard.mozilla.org/r/171294/#review176710
> 
> ::: testing/talos/talos/mitmproxy/mitmproxy.py:84
> (Diff revision 1)
> > +        certificate = _read_certificate(DEFAULT_CERT_PATH)
> > +        contents = read_autoconfig_file(browser_install)
> > +        if (MITMPROXY_SETTINGS % {'cert': certificate}) in contents:
> > +            LOG.info("Verified mitmproxy CA certificate is installed in Firefox")
> > +        else:
> > +            return False
> 
> should we add more info here to expand on the failure  so we don't have to
> guess what was in the contents?

Ok will do, thanks for the review!

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 8899968 [details]
Bug 1366071 - Add check in talos tp6 to ensure mitmproxy certificate was installed successfully;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171294/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebbe081e9554
Add check in talos tp6 to ensure mitmproxy certificate was installed successfully; r=jmaher

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ebbe081e9554