Add check to talos tp6 to ensure mitmproxy certificate was installed

RESOLVED FIXED in Firefox 57

Status

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: rwood, Assigned: rwood)

Tracking

Version 3
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [PI:August])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Improve the talos mitmproxy support (Bug 1357382) by adding a check to verify that the mitmproxy CA certificate was installed into Firefox. The code to install the cert is implemented, but we need a check after because without the certificate mitdump playback won't work with Firefox.

/testing/talos/talos/run_tests.py:is_mitmproxy_cert_installed()
Whiteboard: [PI:June]
(Assignee)

Updated

a year ago
Whiteboard: [PI:June] → [PI:August]
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → rwood
Status: NEW → ASSIGNED
(Assignee)

Updated

a year ago
Summary: Add check to ensure mitmproxy certificate was installed → Add check to talos tp6 to ensure mitmproxy certificate was installed

Comment 3

a year ago
mozreview-review
Comment on attachment 8899968 [details]
Bug 1366071 - Add check in talos tp6 to ensure mitmproxy certificate was installed successfully;

https://reviewboard.mozilla.org/r/171294/#review176710

::: testing/talos/talos/mitmproxy/mitmproxy.py:84
(Diff revision 1)
> +        certificate = _read_certificate(DEFAULT_CERT_PATH)
> +        contents = read_autoconfig_file(browser_install)
> +        if (MITMPROXY_SETTINGS % {'cert': certificate}) in contents:
> +            LOG.info("Verified mitmproxy CA certificate is installed in Firefox")
> +        else:
> +            return False

should we add more info here to expand on the failure  so we don't have to guess what was in the contents?
Attachment #8899968 - Flags: review?(jmaher) → review+
(Assignee)

Comment 4

a year ago
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #3)
> Comment on attachment 8899968 [details]
> Bug 1366071 - Add check in talos tp6 to ensure mitmproxy certificate was
> installed successfully;
> 
> https://reviewboard.mozilla.org/r/171294/#review176710
> 
> ::: testing/talos/talos/mitmproxy/mitmproxy.py:84
> (Diff revision 1)
> > +        certificate = _read_certificate(DEFAULT_CERT_PATH)
> > +        contents = read_autoconfig_file(browser_install)
> > +        if (MITMPROXY_SETTINGS % {'cert': certificate}) in contents:
> > +            LOG.info("Verified mitmproxy CA certificate is installed in Firefox")
> > +        else:
> > +            return False
> 
> should we add more info here to expand on the failure  so we don't have to
> guess what was in the contents?

Ok will do, thanks for the review!
Comment hidden (mozreview-request)

Comment 6

a year ago
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ebbe081e9554
Add check in talos tp6 to ensure mitmproxy certificate was installed successfully; r=jmaher

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ebbe081e9554
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.