Devedition funsize jobs should use "firefox" prefix in "to_mar"

RESOLVED FIXED

Status

enhancement
P1
major
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rail, Assigned: jlorenzo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
https://github.com/mozilla/releasetasks/blob/21ce74e75801f08ca8b1dc3de25e550d1e6e766e/releasetasks/templates/desktop/l10n.yml.tmpl#L195 uses {{ product }} for the file name, which is "devedition", but repacks generate files with "firefox" prefix. We should either parameterize this or hardcode "firefox" (what just worked fine in staging :) ).
(Reporter)

Comment 1

2 years ago
The same applies to FILENAME_TEMPLATE env variables set in enUS and l10n templates
(Assignee)

Updated

2 years ago
Assignee: nobody → jlorenzo
(Assignee)

Comment 2

2 years ago
Posted file releasetasks PR
(Assignee)

Comment 4

2 years ago
Comment on attachment 8869495 [details] [review]
releasetasks PR

Sorry to bother you. Simon realized he doesn't have the right to formally review releasetasks, and I'm not able to override the review requirement.
Attachment #8869495 - Flags: review?(rail)
(Assignee)

Updated

2 years ago
Attachment #8869958 - Flags: review?(rail)
(Reporter)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8869958 [details]
Bug 1366075 - Devedition funsize jobs should use "firefox" prefix in "to_mar"

https://reviewboard.mozilla.org/r/141514/#review145494

::: buildfarm/release/release-runner.py:511
(Diff revision 1)
>                  "update_verify_channel": branchConfig.get("update_verify_channel", {}).get(release["product"]),
>                  "update_verify_requires_cdn_push": branchConfig.get("update_verify_requires_cdn_push", False),
>              }
>  
>              validate_graph_kwargs(queue, gpg_key_path, **kwargs)
>              graph = make_task_graph_strict_kwargs(**kwargs)

You also need to touch `make_task_graph_strict_kwargs()` to make it accept the new argument and adjust https://dxr.mozilla.org/build-central/source/tools/buildfarm/release/releasetasks_graph_gen.py#36 to match the current kwargs for consistency.
Attachment #8869958 - Flags: review?(rail) → review-
(Reporter)

Updated

2 years ago
Attachment #8869495 - Flags: review?(rail) → review+
Comment hidden (mozreview-request)
(Reporter)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8869958 [details]
Bug 1366075 - Devedition funsize jobs should use "firefox" prefix in "to_mar"

https://reviewboard.mozilla.org/r/141514/#review145514
Attachment #8869958 - Flags: review?(rail) → review+
(Assignee)

Comment 9

2 years ago
https://github.com/mozilla/releasetasks/commit/421d8606a93ec51afde19e413950aac26985fbb0

BM85 has been manually updated[1]

[1] Some of the steps are documented here https://github.com/mozilla/releasewarrior/blob/b5094a978955425b867be725fb555707006f637a/how-tos/fennec-temp-relpro.md#start-off-the-fennec-graph mtabara++
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Depends on: 1368627
You need to log in before you can comment on or make changes to this bug.