Closed Bug 1366085 Opened 3 years ago Closed 3 years ago

GC JSON has duplicate keys and does not describe hierarchy

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

eg

  "totals":{
    "mark":20,
    "mark_compartments":7,
    "compact":10,
    "compact_update":6,
    "mark_compartments":5
  }

The first mark_compartments is really mark.mark_compartments, the second is compact.compact_update.mark_compartments.
Sorry, I mixed in some additional extended phase / phase kind renaming, which makes it a little harder to follow and probably will conflict with your recent patch when I try to rebase.
Attachment #8869244 - Flags: review?(jcoppeard)
Oh, and I should mention that I first implemented this in C++. But I did it by making 'path' be mutable and lazily constructed. Which I strongly suspect would have broken on Windows, which has a habit of allocating const things in read-only memory, even if they contain a mutable field.

Fixable easily enough, of course, but having the python do it eliminates some small startup computation and reduces the amount of code.
Comment on attachment 8869244 [details] [diff] [review]
Make JSON output use hierarchical names

Review of attachment 8869244 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for fixing my all my out-of-date comments and bad variable names :)

This all is much nicer.
Attachment #8869244 - Flags: review?(jcoppeard) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77d89866a16d
Make JSON output use hierarchical names, r=jonco
https://hg.mozilla.org/mozilla-central/rev/77d89866a16d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.