1366085 - GC JSON has duplicate keys and does not describe hierarchy

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Steve Fink [:sfink] [:s:]]

eg

  "totals":{
    "mark":20,
    "mark_compartments":7,
    "compact":10,
    "compact_update":6,
    "mark_compartments":5
  }

The first mark_compartments is really mark.mark_compartments, the second is compact.compact_update.mark_compartments.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Make JSON output use hierarchical names

Sorry, I mixed in some additional extended phase / phase kind renaming, which makes it a little harder to follow and probably will conflict with your recent patch when I try to rebase.

Comment 2

[Steve Fink [:sfink] [:s:]]

Oh, and I should mention that I first implemented this in C++. But I did it by making 'path' be mutable and lazily constructed. Which I strongly suspect would have broken on Windows, which has a habit of allocating const things in read-only memory, even if they contain a mutable field.

Fixable easily enough, of course, but having the python do it eliminates some small startup computation and reduces the amount of code.

Comment 3

[Jon Coppeard (:jonco)]

Comment on attachment 8869244 [details] [diff] [review]
Make JSON output use hierarchical names

Review of attachment 8869244 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for fixing my all my out-of-date comments and bad variable names :)

This all is much nicer.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77d89866a16d
Make JSON output use hierarchical names, r=jonco

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/77d89866a16d