Closed Bug 1366102 Opened 3 years ago Closed 3 years ago

Remove the DEVTOOLS_OS_* probes from our Telemetry

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: clarkbw, Assigned: vkatsikaros)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

The data retrieved from these probes isn't being used and is likely more problematic than the system info we get from the telemetry ping.  

OS_ENUMERATED
OS_IS_64_BITS

This isn't urgent, but when someone gets around to it we don't need this anymore.  I'm not using it in my analysis.  Thanks!
Along with this we might as well get rid of the DEVTOOLS_TABS_OPEN_* and DEVTOOLS_TABS_PINNED_* probes as well.  While interesting I don't think its answering useful questions for us anymore.
DevTools bug triage (filter on CLIMBING SHOES).
Keywords: good-first-bug
Priority: -- → P3
Assignee: nobody → vkatsikaros
Status: NEW → ASSIGNED
Attachment #8872697 - Flags: review?(pbrosset) → review?(mratcliffe)
Comment on attachment 8872697 [details]
Bug 1366102 - Remove the DEVTOOLS_OS_* probes from our Telemetry.

https://reviewboard.mozilla.org/r/144236/#review148352

Very clean... thanks for the hard work!
Attachment #8872697 - Flags: review?(mratcliffe) → review+
Hi Michael, I pushed a rebased version, but I didn't spot any differences (checked again to see if the patch still makes sense). I don't think I can land the commit, so if the work is still needed you probably have to trigger this yourself :)
Flags: needinfo?(mratcliffe)
I have triggered a new try run with your rebased patch... if the patch passes we should land it.
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cbb8ee4069d5
Remove the DEVTOOLS_OS_* probes from our Telemetry. r=miker
https://hg.mozilla.org/mozilla-central/rev/cbb8ee4069d5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Flags: needinfo?(mratcliffe)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.