1366129 - When android 'mach mochitest' is interrupted, log file may be left behind

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

With an android build, 'mach mochitest' generates a log file on device which is pulled and presented on the host. If the mach session is interrupted (ctrl-c, killed, etc), the remote log file is left behind, and it looks like it may be displayed on the host the next time 'mach mochitest' is run. That can be confusing and could be one explanation for bug 1364381.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: delete log file, profile on initialization

We already have reasonable code for cleaning up, but it can be interrupted. To handle that case, I think it's best to delete the log file before starting a test run. I noticed a similar vulnerability for the remote profile, so let's delete that too.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b2816fcbc9d4e10e487e7a3a87aa356c4f2dd5b

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8870574 [details] [diff] [review]
delete log file, profile on initialization

Review of attachment 8870574 [details] [diff] [review]:
-----------------------------------------------------------------

good find.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d126d7d281d
Improve cleanup of android mochitest environment before starting tests; r=jmaher

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7d126d7d281d