rewrite dom/html/test/test_fullscreen-api-race.html

RESOLVED FIXED in Firefox 57

Status

()

Core
DOM: Security
P2
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: allstars, Assigned: allstars)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
now the test hits assertion even without flip the pref, bug 1365844
Created attachment 8877940 [details] [diff] [review]
WIP patch
Status: NEW → ASSIGNED
Priority: -- → P2
This one has lots of intermittent failures even without my patch and without flip the pref, Henry is fixing some in his bug 1355746. I'll wait to see if his patch could help the intermittent here.
Per Heny, bug 1355746 is not a blocker for this bug.  Henry, please elaborate it.  Thanks!
Flags: needinfo?(hchang)

Comment 5

3 months ago
(In reply to Ethan Tseng [:ethan] from comment #4)
> Per Heny, bug 1355746 is not a blocker for this bug.  Henry, please
> elaborate it.  Thanks!

The relevant patch in bug 1355746 is to fix test_fullscreen-api.html
intermittent failure caused by a fullscreen focus issue on Linux so I
am not expecting that patch to fix test_fullscreen-api-race.html
Flags: needinfo?(hchang)
Created attachment 8894822 [details] [diff] [review]
Patch.
Attachment #8877940 - Attachment is obsolete: true
Attachment #8894822 - Flags: review?(bugs)
Comment on attachment 8894822 [details] [diff] [review]
Patch.

// SimpleTest.waitForFocus will fire only when we use data: URI.
sounds wrong.
But if we don't want to change data: usage here, this is fine, but without that comment.
Attachment #8894822 - Flags: review?(bugs) → review+
Created attachment 8895180 [details] [diff] [review]
Patch v2.

updated comments
Attachment #8894822 - Attachment is obsolete: true
Attachment #8895180 - Flags: review+

Comment 9

3 months ago
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f39222925a5f
rewrite dom/html/test/test_fullscreen-api-race.html. r=smaug

Comment 10

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f39222925a5f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.