stylo: rendering of <video controls> and <audio controls> is wrong

REOPENED
Assigned to

Status

()

Core
CSS Parsing and Computation
P1
normal
REOPENED
2 months ago
an hour ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 months ago
Created attachment 8869314 [details]
incomplete_rendering_of_video_controls_.png

With the WIP patches in bug 1290276 comment 22, I got an incomplete rendering of <video controls>. (See the attachment.)

At least "-moz-context-properties" is not supported yet (Bug 1366162). I'm not sure what else is missing.

Updated

2 months ago
Priority: -- → P1
Comment hidden (mozreview-request)
(Assignee)

Updated

a month ago
Attachment #8880237 - Attachment is obsolete: true
Attachment #8880237 - Flags: review?(emilio+bugs)
(Assignee)

Comment 2

27 days ago
After bug 1372876 is fixed, the remaining issue for the <video controls> is the :hover rule in [1] for the -moz-range-thumb [2].

.scrubber:hover::-moz-range-thumb,
.volumeControl:hover::-moz-range-thumb {
  background-color: #48a0f7;
}

[1] http://searchfox.org/mozilla-central/rev/fdb811340ac4e6b93703d72ee99217f3b1d250ac/toolkit/themes/shared/media/videocontrols.css#234-237
[2] https://developer.mozilla.org/en-US/docs/Web/CSS/::-moz-range-thumb
Depends on: 1372876
Should that remaining issue be fixed by bug 1375969?
Flags: needinfo?(tlin)
(Assignee)

Comment 4

25 days ago
Yes. Based on my local build, the issue in comment 2 has been fixed by bug 1375969. <video controls> looks the same on gecko and stylo now. Thanks emilio!
Status: NEW → RESOLVED
Last Resolved: 25 days ago
Depends on: 1370797
Flags: needinfo?(tlin)
Resolution: --- → WORKSFORME
(Assignee)

Updated

25 days ago
Depends on: 1375969
(Assignee)

Comment 5

24 days ago
We still have some reftests failed like layout/reftests/bugs/449149-1a.html for <audio controls>.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=48484b37866c8674e8066a2e95826bb0653d0999&selectedJob=111173618
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Assignee: nobody → tlin
You need to log in before you can comment on or make changes to this bug.