Closed Bug 1366169 Opened 3 years ago Closed 3 years ago

Avoid reordered manifest entries creating unexpected overrides

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

cf. the footgun described in https://hg.mozilla.org/mozilla-central/rev/c94e87a18096

I had this thought that we could actually do some sanity check at packaging time that would avoid some foot damage.
Comment on attachment 8869327 [details]
Bug 1366169 - Avoid reordered manifest entries creating unexpected overrides.

https://reviewboard.mozilla.org/r/140882/#review144436

Thanks for following up! Hopefully we prevented ourselves from shipping something on a configuration we didn't mean to ship!
Attachment #8869327 - Flags: review?(gps) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/1100dbb56818
Avoid reordered manifest entries creating unexpected overrides. r=gps
https://hg.mozilla.org/mozilla-central/rev/1100dbb56818
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1366729
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.