Closed Bug 1366218 Opened 4 years ago Closed 4 years ago

HTMLInputElement::IsValueEmpty should use nsTextEditorState::HasNonEmptyValue

Categories

(Core :: DOM: Core & HTML, enhancement)

55 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

HasNonEmptyValue doesn't use DocumentEncoder, so IsValueEmpty can be improved.
Comment on attachment 8870258 [details]
Bug 1366218 - Use fast path to check empty value.

https://reviewboard.mozilla.org/r/141710/#review145528

Bogus node handling in editor is weird, but I guess this should do the trick
Attachment #8870258 - Flags: review?(bugs) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/ffaa07672466
Use fast path to check empty value. r=smaug
https://hg.mozilla.org/mozilla-central/rev/ffaa07672466
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.