HTMLInputElement::IsValueEmpty should use nsTextEditorState::HasNonEmptyValue

RESOLVED FIXED in Firefox 55

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks: 1 bug)

55 Branch
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
HasNonEmptyValue doesn't use DocumentEncoder, so IsValueEmpty can be improved.
Comment hidden (mozreview-request)

Comment 2

a month ago
mozreview-review
Comment on attachment 8870258 [details]
Bug 1366218 - Use fast path to check empty value.

https://reviewboard.mozilla.org/r/141710/#review145528

Bogus node handling in editor is weird, but I guess this should do the trick
Attachment #8870258 - Flags: review?(bugs) → review+

Comment 3

a month ago
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/ffaa07672466
Use fast path to check empty value. r=smaug
https://hg.mozilla.org/mozilla-central/rev/ffaa07672466
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.