Ctrl-enter shortcut isn't working when manually adding a bug

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: KWierso, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
The patch from bug 1305507 doesn't seem to be working anymore for some reason. When the manual bug entry field is focused, the Ctrl-Enter shortcut doesn't trigger at all, like it's stealing all focus and not emitting the event.

Comment 1

8 months ago
Created attachment 8869552 [details] [review]
[treeherder] KWierso:b1366345 > mozilla:master
(Assignee)

Updated

8 months ago
Assignee: nobody → wkocher
(Assignee)

Updated

8 months ago
Attachment #8869552 - Flags: review?(emorley)

Comment 2

8 months ago
Comment on attachment 8869552 [details] [review]
[treeherder] KWierso:b1366345 > mozilla:master

Redirecting to Cameron, since he might know if there's a better way to do this :-)
Attachment #8869552 - Flags: review?(emorley) → review?(cdawson)

Updated

8 months ago
Attachment #8869552 - Flags: review?(cdawson) → review+
As I stated in the PR, I wouldn't worry about the ``meta`` key which corresponds to the mac "command" key.  Since the user guide only says ``ctrl`` I'd just go with that.

Interesting this stopped working at some point.  I suspect it was a JS upgrade somewhere (perhaps AngularJS itself?) that happened a while back and nobody noticed till recently.  :)

Comment 4

8 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/da2c74b8b1b53829a932e851d0e9c1690b7801b2
Bug 1366345 - Force the save() event to be emitted when ctrl-enter is used while manually entering bug numbers (#2494) r=camd

Something is eating the event fired when ctrl-enter is pressed to save classifications if the manual bug number field is focused, making the user press ctrl-enter twice to save the classification.  This patch adds a keypress listener to the bug entry field which forces the save() function to get called when ctrl-enter is pressed.
(Assignee)

Updated

8 months ago
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.