Expand talos quantum-pageload test (mitmproxy) to other platforms

RESOLVED FIXED in Firefox 58

Status

Testing
Talos
RESOLVED FIXED
5 months ago
11 days ago

People

(Reporter: rwood, Assigned: rwood)

Tracking

(Blocks: 1 bug)

Version 3
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
Right now the priority is Windows 7/10 (Bug 1357382). Once that is up and running and stable, expand the talos quantum-pageload test to OSX and Linux. This will at minimum include:

- Creating a Python 3.6 package for those platforms and making it available for download via tooltool;
- ensuring a python3 virtualenv can be created and mitmproxy can be installed correctly on those platforms;
- adjusting all of the mitmproxy/mitmdump paths/command lines as necessary, etc.
(Assignee)

Updated

5 months ago
Depends on: 1371021
I believe we want to do osx in the short term; I think using a shortcut of reusing the same recorded pageset for windows is ok assuming it works.
Whiteboard: [PI:August]
Blocks: 1387265
(Assignee)

Updated

2 months ago
Whiteboard: [PI:August] → [PI:September]
(Assignee)

Updated

19 days ago
Whiteboard: [PI:September] → [PI:October]
(Assignee)

Updated

19 days ago
Whiteboard: [PI:October]
(Assignee)

Comment 2

16 days ago
Tp6 is running in production on Win & OSX, last up is linux x64, I'll use this bug for that patch. Here's a try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9287c95aae9b80978d4699f284b7acc2305ffe6f
Comment hidden (mozreview-request)
(Assignee)

Updated

16 days ago
Assignee: nobody → rwood
Status: NEW → ASSIGNED

Comment 4

16 days ago
mozreview-review
Comment on attachment 8915994 [details]
Bug 1366355 - Expand talos tp6 suite to linux x64;

https://reviewboard.mozilla.org/r/187282/#review192294

a few nits, really close to r+

::: taskcluster/ci/test/test-sets.yml:148
(Diff revision 1)
>      - talos-other-stylo-disabled
>      - talos-svgr-stylo-disabled
>      - talos-tp5o-stylo-disabled
>      - talos-perf-reftest-stylo-disabled
>      - talos-perf-reftest-singletons-stylo-disabled
> +    - talos-tp6-stylo-disabled

what about stylo-threads

::: testing/mozharness/mozharness/mozilla/testing/talos.py:422
(Diff revision 1)
>              self.info("Skipping: mitmproxy is not required")
>              return
>  
>          # tp6 is supported in production only on win and macosx
>          os_name = self.platform_name()
> -        if 'win' not in os_name and os_name != 'macosx':
> +        if 'win' not in os_name and os_name != 'linux64' and os_name != 'macosx':

is there any other platform?  Maybe we can remove this?

::: testing/mozharness/mozharness/mozilla/testing/talos.py:467
(Diff revision 1)
>              self.mitmdump = os.path.join(mitmproxy_path, 'mitmdump')
>              if not os.path.exists(self.mitmdump):
>                  # download the mitmproxy release binary; will be overridden by the --no-download
>                  if '--no-download' not in self.config['talos_extra_options']:
> -                    self.query_mitmproxy_rel_bin('osx')
> +                    if 'osx' in self.platform_name():
> +                        _pform = 'osx'

can we use _platform instead of _pform?
Attachment #8915994 - Flags: review?(jmaher) → review-
(Assignee)

Updated

16 days ago
Depends on: 1406404
Comment hidden (mozreview-request)

Comment 6

12 days ago
mozreview-review
Comment on attachment 8915994 [details]
Bug 1366355 - Expand talos tp6 suite to linux x64;

https://reviewboard.mozilla.org/r/187282/#review193220

one small nit

::: testing/mozharness/mozharness/mozilla/testing/talos.py:492
(Diff revisions 1 - 2)
>          self.info("Downloading the mitmproxy release binary using tooltool")
>          dest = os.path.join(self.talos_path, 'talos', 'mitmproxy')
>          _manifest = "mitmproxy-rel-bin-%s.manifest" % platform
>          manifest_file = os.path.join(self.talos_path, 'talos', 'mitmproxy', _manifest)
>  
> -        if platform == 'osx':
> +        if platform == 'osx' or platform == 'linux64:':

'linux64' has a : in it.  Could you rewrite:
if platform in ['osx', 'linux64']:
Attachment #8915994 - Flags: review?(jmaher) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 9

12 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c7e760ff1e73f68b8caad4c656d4f5478f4f541
(Assignee)

Comment 10

12 days ago
Update, tp6 shouldn't be added to the 'date' repo (and xperf shouldn't be there anymore either). Going to remote xperf from 'date' in this patch also while I'm at it.

From IRC:

<rwood> aki: hey, I notice on the 'date' repo, talos tp6 and xperf are running (but nothing else). Should they be removed?? Or should all other talos tests be added? Just wondering if it should be made consistent
2:04 PM 
<rwood> http://searchfox.org/mozilla-central/rev/b53e29293c9e9a2905f4849f4e3c415e2013f0cb/taskcluster/ci/test/tests.yml#1760
2:05 PM 
<aki> rwood: we're retiring the `date` repo, so we should consistently reduce the tasks running to 0 :)
2:05 PM 
<rwood> aki: ok perfect haha I'll remove those talos ones, thanks
Comment hidden (mozreview-request)
(Assignee)

Comment 12

12 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=556f93ec9c1793d2ad464dc8d900243bd7fd3ae0

Comment 13

12 days ago
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ac0d5e4f556
Expand talos tp6 suite to linux x64; r=jmaher
https://hg.mozilla.org/mozilla-central/rev/0ac0d5e4f556
Status: ASSIGNED → RESOLVED
Last Resolved: 11 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.