Rename Compact Dark and Compact Light themes to just "Dark" and "Light"

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Toolbars and Customization
P1
normal
VERIFIED FIXED
7 months ago
4 months ago

People

(Reporter: dao, Assigned: mkohler)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [photon-visual][p1][57])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

7 months ago
Firefox 57 will have compact and touch modes independently from current compact themes, but we want to keep these themes as dark/light alternatives to the default. We need to rename them accordingly.
(Reporter)

Updated

7 months ago
Blocks: 1366369
(Reporter)

Updated

7 months ago
Priority: -- → P2
(Reporter)

Updated

7 months ago
Flags: qe-verify+

Updated

7 months ago
QA Contact: brindusa.tot
(Assignee)

Comment 1

7 months ago
What should this be renamed to? I'm happy to do this if you tell me the new names. :)
(Reporter)

Comment 2

7 months ago
This will have to wait till Nightly 57.

The new names should perhaps just be "Light" and "Dark". I don't have a better idea. Will need to check with Shorlander.

Updated

7 months ago
Blocks: 1367284
(Reporter)

Updated

7 months ago
No longer blocks: 1367284

Updated

7 months ago
See Also: → bug 1367419
(Reporter)

Updated

7 months ago
See Also: bug 1367419
(Reporter)

Updated

6 months ago
Duplicate of this bug: 1176577
(Reporter)

Updated

6 months ago
Blocks: 1176577

Updated

5 months ago
See Also: → bug 1379778
(Reporter)

Updated

5 months ago
See Also: bug 1379778
Duplicate of this bug: 1379778
(Reporter)

Updated

5 months ago
Summary: Rename Compact Dark and Compact Light themes → Rename Compact Dark and Compact Light themes to just "Dark" and "Light"
Comment hidden (mozreview-request)
(Assignee)

Comment 6

5 months ago
How should we handle "compact" references and IDs?

Examples:
https://dxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#1241 (do we need a migration?)
https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-compacttheme.js#10
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 7

5 months ago
I don't think we need to worry about internal IDs for now, they're not visible to users in any way.
Flags: needinfo?(dao+bmo)
(Assignee)

Updated

5 months ago
Attachment #8893520 - Flags: review?(dao+bmo)
(Reporter)

Comment 8

5 months ago
mozreview-review
Comment on attachment 8893520 [details]
Bug 1366363 - Rename Compact Dark and Compact Light themes to just 'Dark' and 'Light'

https://reviewboard.mozilla.org/r/164608/#review169934

::: browser/components/nsBrowserGlue.js:630
(Diff revision 1)
>        LightweightThemeManager.addBuiltInTheme({
>          id: "firefox-compact-light@mozilla.org",
> -        name: gBrowserBundle.GetStringFromName("compactLightTheme.name"),
> -        description: gBrowserBundle.GetStringFromName("compactLightTheme.description"),
> +        name: gBrowserBundle.GetStringFromName("lightTheme.name"),
> +        description: gBrowserBundle.GetStringFromName("lightTheme.description"),
>          headerURL: "resource:///chrome/browser/content/browser/defaultthemes/compact.header.png",
> -        iconURL: "resource:///chrome/browser/content/browser/defaultthemes/compactlight.icon.svg",
> +        iconURL: "resource:///chrome/browser/content/browser/defaultthemes/light.icon.svg",

The iconURL change is broken because you didn't rename the SVG file itself...

You could either revert this change or rename the SVG file.
Attachment #8893520 - Flags: review?(dao+bmo)

Updated

5 months ago
Assignee: nobody → me
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment hidden (mozreview-request)
(Reporter)

Comment 10

5 months ago
mozreview-review
Comment on attachment 8893520 [details]
Bug 1366363 - Rename Compact Dark and Compact Light themes to just 'Dark' and 'Light'

https://reviewboard.mozilla.org/r/164608/#review169946

Thanks!
Attachment #8893520 - Flags: review?(dao+bmo) → review+
(Assignee)

Comment 11

5 months ago
mozreview-review
Comment on attachment 8893520 [details]
Bug 1366363 - Rename Compact Dark and Compact Light themes to just 'Dark' and 'Light'

https://reviewboard.mozilla.org/r/164608/#review169950
Attachment #8893520 - Flags: review+
(Assignee)

Updated

5 months ago
Attachment #8893520 - Flags: review+

Comment 12

5 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f96fc2c078c
Rename Compact Dark and Compact Light themes to just 'Dark' and 'Light' r=dao
This seems to have caused a spike in failures like https://treeherder.mozilla.org/logviewer.html#?job_id=120808860&repo=autoland

This was a previously known intermittent but starting on your push, it started failing multiple times per push.

Backed out in https://hg.mozilla.org/integration/autoland/rev/a4e153426d4c5b2b862446c1e975530e9054dc72
Flags: needinfo?(me)
Hrm, those failures are still frequently happening on the backout... I guess this can reland as-is.
(Assignee)

Updated

4 months ago
Flags: needinfo?(me)
Keywords: checkin-needed
You're going to need to reopen the mozreview request if you want someone to land it for you.
Flags: needinfo?(me)

Comment 16

4 months ago
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/64526a900fd5
Rename Compact Dark and Compact Light themes to just 'Dark' and 'Light' r=dao
Keywords: checkin-needed
(Assignee)

Updated

4 months ago
Flags: needinfo?(me)

Updated

4 months ago
Duplicate of this bug: 1387293
https://hg.mozilla.org/mozilla-central/rev/64526a900fd5
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Updated

4 months ago
Iteration: --- → 57.1 - Aug 15

Comment 19

4 months ago
https://hg.mozilla.org/projects/date/rev/3f96fc2c078cc6b6b150bbc191dbbaf2b9f39eea
Bug 1366363 - Rename Compact Dark and Compact Light themes to just 'Dark' and 'Light' r=dao

https://hg.mozilla.org/projects/date/rev/64526a900fd51d1fb784fca7eac2ae9b0bae30d1
Bug 1366363 - Rename Compact Dark and Compact Light themes to just 'Dark' and 'Light' r=dao

Comment 20

4 months ago
Managed to reproduce the issue on an affected build. Bug 1366363 is fixed & verified.
Version : Firefox Nightly 57.0a1
build ID: 20170809100326
OS      :Windows 10 X 64 bit. 

[bugday-20170809]
status-firefox57: fixed → verified
I tested this issue on Mac Os X 10.12, Windows 10 x64, Ubuntu 16.04 with FF Nightly 57.0a1(2017-08-11) Compact Dark and Compact Light themes are now renamed to "Dark" and "Light". I will mark this as verified fixed.
Status: RESOLVED → VERIFIED

Updated

4 months ago
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.