Closed Bug 1366366 Opened 4 years ago Closed 4 years ago

Remove animation from new robot icon as introduced in bug

Categories

(Testing :: Marionette, defect, P2)

defect

Tracking

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: whimboo, Assigned: ato)

References

Details

(Keywords: regression)

Attachments

(2 files)

Since the patch on bug 1355890 landed we see a lot of test failures for the full screenshot test on bug 1364762. As investigation on bug 1364762 has shown this happens because the robot is animated (rolling eyes).

I wonder if we should better remove this animation.
Flags: needinfo?(ato)
I think removing the animation is prudent.
Flags: needinfo?(ato)
Priority: -- → P2
Andreas, this is the reason for bug 1364762 which has a massive increase of failures. For last week it's the #3 top OF failure. So we need to remove the animation or skip the test ASAP. Thanks.
Assignee: nobody → ato
Flags: needinfo?(ato)
Also it looks like that we overdraw the location bar border.
Not sure what the needinfo is for.
Flags: needinfo?(ato)
Comment on attachment 8870394 [details]
Bug 1366366 - Use non-animated robot icon with Marionette;

https://reviewboard.mozilla.org/r/141844/#review145490

rs=me, but can we either name this 'static-robot' or something, or rename the other icon, to avoid this happening to other people who accidentally use the 'wrong' icon? :-)
Attachment #8870394 - Flags: review?(gijskruitbosch+bugs) → review+
Status: NEW → ASSIGNED
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d90b1a36e1a
Use non-animated robot icon with Marionette; r=Gijs
https://hg.mozilla.org/mozilla-central/rev/5d90b1a36e1a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.