Review HTTP error response pages, and add links to HTTP response code docs
Categories
(developer.mozilla.org Graveyard :: General, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: jswisher, Unassigned)
References
Details
(Keywords: good-first-bug, in-triage, Whiteboard: [specification][type:change][points=1])
Updated•7 years ago
|
Comment 2•6 years ago
|
||
I would love to work on this. Can I please be guided on how to be involved with this? I am very new on here and would love for this to be the first issue I address. Thanks.
Comment 3•6 years ago
|
||
saphal1998: I no longer work at Mozilla and so I'm no longer a suitable mentor for this bug. (I'd forgotten that I was listed here.)
Our backend is a Django server and the error pages are implemented as jinja2 templates. IIRC they are located in the top-level templates directory, so they should be straightforward to find and update. What is proposed here is simply to add links to those pages. Florian is probably a good person to approve your wording changes.
Good luck, and thank you for contributing!
Comment 4•6 years ago
|
||
It appears that with my non-employee account I can't remove myself as mentor.
Comment 6•6 years ago
|
||
I'm not a Kuma developer, but I can provide educated guesses here.
Looks like the template is https://github.com/mozilla/kuma/blob/master/jinja2/404.html
After line 33, I would add something similar to this:
<p>In the MDN <a href="https://developer.mozilla.org/docs/Web/HTTP">HTTP</a> documentation,
you can learn more about the <a href="https://developer.mozilla.org/docs/Web/HTTP/Status/404">404 error code</a>.</p>
To translate this, you will tweak this code a bit and add {% trans %} or something. Also, I'm not quite sure how to create links correctly as the other snippets have <a href="{{ homepage_url }}">home page</a>, for example.
You can probably find this out by talking to a Kuma engineer, either by just opening a PR and start a discussion there or by going into #mdndev irc.
Thanks for your interest in contributing!
Comment 7•6 years ago
|
||
This is how you'd do it with the translation tags:
<p>
{% trans http_link='https://developer.mozilla.org/docs/Web/HTTP', 404_link='href="https://developer.mozilla.org/docs/Web/HTTP/Status/404' %}
In the MDN <a href="{{ http_link }}">HTTP</a> documentation,
you can learn more about the <a href="{{ 404_link }}">404 error code</a>.
{% endtrans %}
</p>
:)
Comment 8•6 years ago
|
||
Hi, I am looking to work on this as my first bug.
Can I have some help on how to see changes we made to the HTTP error pages (such as 404)?
If the DEBUG flag is set to True Django does not show the custom 404 page. but when I set the flag to False, Kuma doesn't run in my local machine.
| Reporter | ||
Comment 9•6 years ago
|
||
Hi Michael! The MDN Dev team now tracks issues in GitHub. What's left here in Bugzilla is old, low-priority issues. I've created a new github issue corresponding to this one. Check there for responses.
Comment 10•6 years ago
|
||
Updated•6 years ago
|
Description
•