Closed Bug 1366394 Opened 5 years ago Closed 5 years ago

More than 3% of Safe Browsing updates time out

Categories

(Toolkit :: Safe Browsing, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: francois, Assigned: francois)

References

Details

(Whiteboard: #sbv4-m7)

Attachments

(1 file)

Whiteboard: #sbv4-m7
Comment on attachment 8869596 [details]
Bug 1366394 - Bump the Safe Browsing update timeout to 15s.

https://reviewboard.mozilla.org/r/141176/#review144954

Thanks Francois :) 

Just out of curiosity, how do we come out with the new timeout value?
Does it come from another telemetry probe? (We seemed to discuss about
this issue but cannot clear recall) Thanks!
Attachment #8869596 - Flags: review?(hchang) → review+
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9353b09c2ec9
Bump the Safe Browsing update timeout to 15s. r=hchang
Thanks for the review Henry.

(In reply to Henry Chang [:hchang] from comment #3)
> Just out of curiosity, how do we come out with the new timeout value?
> Does it come from another telemetry probe?

Here's my reasoning for the 15 seconds: I made it 3 times larger in the hope that this we will see 3 times less timeouts. It seemed like a large enough number to allow very networks to get updates, but it's also 4 times smaller than the overall update timeout (60 seconds).

I plan on monitoring the timeouts with this new value and re-adjusting again if necessary.
https://hg.mozilla.org/mozilla-central/rev/9353b09c2ec9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.