1366424 - Drop down marker of folder on Bookmark Toolbar is unnecessary

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: Surplus space is needed fir the drop down marker. And Violation ux-minimalism

Drop down marker of folder on Bookmark Toolbar is unnecessary.

Reason:

1. Surplus space is needed fir the drop down marker.
2. There are already folder icon. There is no way for confusion.
3. Menu item in Menu bar do not have drop down marker.
4. Menu Button do not have drop down marker.

Comment 1

[Alice0775 White]

Attachment: screenshot

It look messy.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=df404e72597d2754290a95a18782ec31bc0027b3&tochange=a4235c4be96edaf90b5d6d7c20272a8761ca2339

Regressed by:
	01ae37c9efc0	Johann Hofmann — Bug 1361686 - Share bookmark toolbar button styling between platforms. r=dao

Comment 3

[Dão Gottwald [:dao]]

I'm starting to think we should just remove this across platforms...

Comment 4

[Johann Hofmann [:johannh]]

Up to shorlander, really. I don't mind either way. I can see that it has its virtues and it has been there on non-Windows platforms for a long time without anyone opening a bug for it afaik. But we can also remove it. It's part of the Photon spec cross-platform, that's why I enabled it on Windows.

Comment 5

[Antti Tervasmäki]

For me it makes my bookmarks toolbar 21 "arrows" wider, which I don't like. 
RSS feeds are treated as folders, do they need to be?

Comment 6

[Julien Cristau [:jcristau]]

Not tracking for 55, I will let the photon team handle this :)

Comment 7

[Stephen Horlander [:shorlander]]

Yeah the arrow is redundant since we also have the folder icon(s) to indicate that is has a menu. Let's remove it everywhere and save some space.

Comment 8

[Dão Gottwald [:dao]]

Already discussed in the meeting that we should do this.

[Tracking Requested - why for this release]: This needs to be fixed in 55 so that we don't regress how many bookmarks can fit in the toolbar on Windows.

Comment 9

[Marcia Knous [:marcia]]

Tracking 55+ based on Comment 8.

Comment 10

[Dão Gottwald [:dao]]

Attachment: Bug 1366424 - Remove dropdown arrow from bookmarks toolbar folders.

The arrow is redundant since we also have the folder icons to indicate what has a menu.

Review commit: https://reviewboard.mozilla.org/r/143196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143196/

Comment 11

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8871690 [details]
Bug 1366424 - Remove dropdown arrow from bookmarks toolbar folders.

https://reviewboard.mozilla.org/r/143196/#review146922

Thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/958964b3117b
Remove dropdown arrow from bookmarks toolbar folders. r=nhnt11

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for bustage on OS X: arrow-down.svg not found:

https://hg.mozilla.org/integration/autoland/rev/25713e57068200e3f4705aded940270531fd8c03

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=958964b3117b5a6e6215d1710ddd739090e21b8a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=102311770&repo=autoland
> RuntimeError: File "../shared/places/arrow-down.svg" not found in /home/worker/workspace/build/src/browser/themes/osx, /home/worker/workspace/build/src/obj-firefox/browser/themes/osx

Relevant code: https://dxr.mozilla.org/mozilla-central/rev/f7adbf457ee20eeffde72694e0d17d73616e3cfd/browser/themes/shared/jar.inc.mn#188-190

Comment 14

[Dão Gottwald [:dao]]

Apparently shared/jar.mn.inc wasn't part of my patch although I'm pretty sure I modified it...

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 8871690 [details]
Bug 1366424 - Remove dropdown arrow from bookmarks toolbar folders.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143196/diff/1-2/

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36094daddfd1
Remove dropdown arrow from bookmarks toolbar folders. r=nhnt11

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/36094daddfd1

Comment 18

[Almas Hossain[:mAlmas]]

I have reproduce this bug with Nightly 55.0a1 (2017-05-19) (64-bit) in Windows 10.

This bug's fix is verified with latest Nightly 55.0a1 (64-bit).
 
Build ID   :    20170529030204
User Agent :	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0



[bugday-20170524]

Comment 19

[Tanvir Rahman]

I have reproduced this bug with Nightly 55.0a1 (2017-05-19) on Ubuntu 16.04, 64 bit!

The fix is now verified on latest Nightly!

Build ID 	20170531100318
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

As per Comment 18 & Comment 19, I am also marking this bug as verified fixed.

Comment 20

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=1bfa4578aa56f768626ba278a6929e23fc48db54&newProject=mozilla-central&newRev=ba1a33add29df1cff5931c5bd82725b8ed4990e5&filter=alltoolbars