Closed Bug 1366424 Opened 2 years ago Closed 2 years ago
Drop down marker of folder on Bookmark Toolbar is unnecessary
[Tracking Requested - why for this release]: Surplus space is needed fir the drop down marker. And Violation ux-minimalism Drop down marker of folder on Bookmark Toolbar is unnecessary. Reason: 1. Surplus space is needed fir the drop down marker. 2. There are already folder icon. There is no way for confusion. 3. Menu item in Menu bar do not have drop down marker. 4. Menu Button do not have drop down marker.
It look messy.
Summary: Drop down marker of folder on Bookmark Toolbar is unnecessary. → Drop down marker of folder on Bookmark Toolbar is unnecessary. It looks messy.
Regression window: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=df404e72597d2754290a95a18782ec31bc0027b3&tochange=a4235c4be96edaf90b5d6d7c20272a8761ca2339 Regressed by: 01ae37c9efc0 Johann Hofmann — Bug 1361686 - Share bookmark toolbar button styling between platforms. r=dao
I'm starting to think we should just remove this across platforms...
Up to shorlander, really. I don't mind either way. I can see that it has its virtues and it has been there on non-Windows platforms for a long time without anyone opening a bug for it afaik. But we can also remove it. It's part of the Photon spec cross-platform, that's why I enabled it on Windows.
For me it makes my bookmarks toolbar 21 "arrows" wider, which I don't like. RSS feeds are treated as folders, do they need to be?
2 years ago
Summary: Drop down marker of folder on Bookmark Toolbar is unnecessary. It looks messy and noisy. → Drop down marker of folder on Bookmark Toolbar is unnecessary
Yeah the arrow is redundant since we also have the folder icon(s) to indicate that is has a menu. Let's remove it everywhere and save some space.
OS: Windows 10 → All
Priority: -- → P2
Hardware: Unspecified → All
Whiteboard: [photon-visual][p1] → [photon-visual][p1] [triage]
Already discussed in the meeting that we should do this. [Tracking Requested - why for this release]: This needs to be fixed in 55 so that we don't regress how many bookmarks can fit in the toolbar on Windows.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Comment on attachment 8871690 [details] Bug 1366424 - Remove dropdown arrow from bookmarks toolbar folders. https://reviewboard.mozilla.org/r/143196/#review146922 Thanks!
Attachment #8871690 - Flags: review?(nhnt11) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/958964b3117b Remove dropdown arrow from bookmarks toolbar folders. r=nhnt11
Backed out for bustage on OS X: arrow-down.svg not found: https://hg.mozilla.org/integration/autoland/rev/25713e57068200e3f4705aded940270531fd8c03 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=958964b3117b5a6e6215d1710ddd739090e21b8a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=102311770&repo=autoland > RuntimeError: File "../shared/places/arrow-down.svg" not found in /home/worker/workspace/build/src/browser/themes/osx, /home/worker/workspace/build/src/obj-firefox/browser/themes/osx Relevant code: https://dxr.mozilla.org/mozilla-central/rev/f7adbf457ee20eeffde72694e0d17d73616e3cfd/browser/themes/shared/jar.inc.mn#188-190
Apparently shared/jar.mn.inc wasn't part of my patch although I'm pretty sure I modified it...
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/36094daddfd1 Remove dropdown arrow from bookmarks toolbar folders. r=nhnt11
2 years ago
Depends on: 1368580
I have reproduce this bug with Nightly 55.0a1 (2017-05-19) (64-bit) in Windows 10. This bug's fix is verified with latest Nightly 55.0a1 (64-bit). Build ID : 20170529030204 User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday-20170524]
I have reproduced this bug with Nightly 55.0a1 (2017-05-19) on Ubuntu 16.04, 64 bit! The fix is now verified on latest Nightly! Build ID 20170531100318 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 As per Comment 18 & Comment 19, I am also marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
QA Whiteboard: [bugday-20170531]
You need to log in before you can comment on or make changes to this bug.