Closed
Bug 1366474
Opened 7 years ago
Closed 7 years ago
Element::{Get,Set}SMILOverrideDeclaration don't seem to need to be virtual.
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(2 files)
We call these unconditionally from Servo, and when skimming over them there doesn't seem to be anyone actually overriding them.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
I suspect this was originally needed, but bug 811449 fixed that.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8869696 [details] Bug 1366474: Devirtualize Element::{Get,Set}SMILOverrideStyleDeclaration. https://reviewboard.mozilla.org/r/141276/#review144938
Attachment #8869696 -
Flags: review?(bbirtles) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8869697 [details] Bug 1366474: While we're here, devirtualize GetSMILOverrideStyle too. https://reviewboard.mozilla.org/r/141278/#review144940
Attachment #8869697 -
Flags: review?(bbirtles) → review+
Comment 6•7 years ago
|
||
Thanks for finding this and fixing it!
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c91c70a13c4a Devirtualize Element::{Get,Set}SMILOverrideStyleDeclaration. r=birtles https://hg.mozilla.org/integration/autoland/rev/367944041b55 While we're here, devirtualize GetSMILOverrideStyle too. r=birtles
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c91c70a13c4a https://hg.mozilla.org/mozilla-central/rev/367944041b55
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•