1366477 - Regression :Session restore breaks after restarting firefox 55 if pages are loading

Status: RESOLVED INCOMPLETE

(Firefox :: Session Restore, defect, P3)

Description

[u595641]

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170519030205

Steps to reproduce:

new profile

set restore from previous session.

Open a bunch of bookmarks say 10,

&

Shift + F2, then type "restart" Enter.

session is lost.

This started happening recently and in Firefox 55 cycle.

work on Firefox 52.0.1

Comment 1

[u595641]

Not sure what patch broke it and it's very useful while testing extensions/webrender

but in recent weeks these were the changes which might have broken it

So NI you guys as you guys know abut this more than me.

Bug 1357098 , Bug 1359806 , Bug 1362058 , Bug 1364127 , Bug 1364127

Comment 2

[u595641]

Forgot to mention it also happens with extensions like restart less restart (legacy)
and when sometimes restarting after extension installation (Legacy/webextension)

Comment 3

[Loic]

I tried a few times to restart Nightly with 8 tabs open, the session restore worked normally, no tab loss.

Comment 4

[u595641]

(In reply to Loic from comment #3)
> I tried a few times to restart Nightly with 8 tabs open, the session restore
> worked normally, no tab loss.

Well can reproduce it here,
just open 15-20 bookmarks, while they start to load
quickly Shift + F2, then type "restart" Enter,
or use this for ease 

https://github.com/vanowm/restartless-restart-ffext/raw/master/restartless.restart%40erikvold.com_v9.1.2.xpi

Comment 5

[u595641]

Attachment: error.jpg

This is whats happening.

If you cannot reproduce easily use the addon in the above comment , it make it easier

Is there any way to login a file all the processes/things happening?
So that might help catch the issue.

Comment 6

[u595641]

https://crash-stats.mozilla.com/report/index/531fe877-f1bf-4614-99b2-57ee70170520#tab-details

Comment 7

[Loic]

I still can't reproduce it.

Comment 8

[Matt]

I have seen something very similar to this a couple times. And just with normal restarts. Never got the "difficulty restoring" just blank tabs and nothing loading. Did lose my session/tabs each time.

Twice over the past couple weeks. Most times everything is fine.

Comment 9

[u595893]

(In reply to Matt from comment #8)
> I have seen something very similar to this a couple times. And just with
> normal restarts. Never got the "difficulty restoring" just blank tabs and
> nothing loading. Did lose my session/tabs each time.
> 
> Twice over the past couple weeks. Most times everything is fine.

Had the same issue couple of times recently and could not restore from backup too

Comment 10

[u595893]

Also see bug 1352706

Comment 11

[avada]

(In reply to shellye from comment #9)
> (In reply to Matt from comment #8)
> > I have seen something very similar to this a couple times. And just with
> > normal restarts. Never got the "difficulty restoring" just blank tabs and
> > nothing loading. Did lose my session/tabs each time.
> > 
> > Twice over the past couple weeks. Most times everything is fine.
> 
> Had the same issue couple of times recently and could not restore from
> backup too

I had something like this. Only three empty tabs were restored instead of several. I could work around it in the Session Manager addon. By not selecting all the tabs and appending them to the window.

Comment 12

[u595893]

Attachment: prefs.js

Using this and constantly loosing session.
usually happens 
1:if open loads of tabs, close/open a few times.

2:install a webextension, eg ABP/UBo and restarting a few times.

3: Copy files in backgrounf ie stress HHD and try steps 1 & 2


Clearing History and all data and repeating 1 or 2 or 3 will most likely result
in dataloss.

Comment 13

[u595893]

can you guys help as constantly loosing my session in near vanilla profile
attached my pref
[e-mail]

Comment 14

[u595893]

Kevin this stated after you landed lazy tabs,
can you please look into it please?

Comment 15

[Asteaguinity]

Could this potentially be related to Bug 1388628? Even if the cause seems to be different at first glance, the symptoms at least resemble that bug...

Comment 16

[u595893]

(In reply to Asteaguinity from comment #15)
> Could this potentially be related to Bug 1388628? Even if the cause seems to
> be different at first glance, the symptoms at least resemble that bug...

This is happening sin 55
so that bug is a variant of this?

Comment 17

[u595893]

Think found a reliable STR

Settings- restore previous session,
Change home page
to-different than default page that is anything 


Used this for sake of testing about:support


1:Load ten tabs, close Firefox and restart.


2: load group of bookmarks eg 20 at once
close firefox while they are loading ,
restart

Sessions are lost

Comment 18

[u595893]

Attachment: New Vanilla profile settings in which can easily reproduce

Use this pref with firefox 55/56/57
to easily reproduce the issue.

Comment 19

[u595893]

Forgot to mention

after replacing the pref file provided with your profile's one


Can reproduce in FF55(55.0.1) FF56(b5) FF57(today's build)
Can it be fixed in stable please.

Comment 20

[u462496]

(In reply to shellye from comment #14)
> Kevin this stated after you landed lazy tabs,
> can you please look into it please?

I think the first place to start would be to get the exact date of the regression as Dao suggested.  Can someone who is consistently able to reproduce this find that out please?  You can follow this guide here:

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Mozmill/How_to_do_regression_testing

Comment 21

[Worcester12345]

If this goes beyond just version 55, that should probably be taken out of the title.

Comment 22

[u601173]

Hey guys hitting this regularly with Firefox 55.0.3 32bit & Firefox 57
any fix incoming as session is lost almost regularly :(

Comment 23

[u462496]

(In reply to hulmelo from comment #22)
> Hey guys hitting this regularly with Firefox 55.0.3 32bit & Firefox 57
> any fix incoming as session is lost almost regularly :(

Please see comment 20.

Comment 24

[Worcester12345]

(In reply to Worcester12345 from comment #21)
> If this goes beyond just version 55, that should probably be taken out of
> the title.

(In reply to hulmelo from comment #22)
> Hey guys hitting this regularly with Firefox 55.0.3 32bit & Firefox 57
> any fix incoming as session is lost almost regularly :(

55 & 57 now. 56?

Comment 25

[u601173]

(In reply to Kevin Jones from comment #23)
> (In reply to hulmelo from comment #22)
> > Hey guys hitting this regularly with Firefox 55.0.3 32bit & Firefox 57
> > any fix incoming as session is lost almost regularly :(
> 
> Please see comment 20.

Trying..(In reply to Worcester12345 from comment #24)
> (In reply to Worcester12345 from comment #21)
> > If this goes beyond just version 55, that should probably be taken out of
> > the title.
> 
> (In reply to hulmelo from comment #22)
> > Hey guys hitting this regularly with Firefox 55.0.3 32bit & Firefox 57
> > any fix incoming as session is lost almost regularly :(
> 
> 55 & 57 now. 56?

Did not test 56  beta.

Comment 26

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.

Comment 27

[Florencia Di Ciocco, NI to vbalducci]

Hi,
I'm trying to see if this bug is still occurring and I'm not being able to reproduce it. Have you had this issue lately?

Thanks in advance, Flor.

Comment 28

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:dao, since the bug has high severity, could you have a look please?

For more information, please visit auto_nag documentation.