+++ This bug was initially created as a clone of Bug #1363421 +++ This looks like rehashing what was done for bug 1352381: https://hg.mozilla.org/comm-central/rev/0e469cfeb978ddc6a9e6114b4da3ecedd870ff14 M-C did this: https://hg.mozilla.org/integration/autoland/rev/bc372bd6dff3 So it looks like we rip out what was done in bug 1352381 and add this instead: +@RESPATH@/components/UAOverridesBootstrapper.js +@RESPATH@/components/UAOverridesBootstrapper.manifest
This should work for TB. SM has still a: if (Services.prefs.getBoolPref("general.useragent.complexOverride.moodle")) UserAgentOverrides.addComplexOverride(addMoodleOverride); I think this needs to be removed too. But then the pref is also no more needed. Frank-Rainer, what should I do? IB has no UserAgentOverrides, I also don't add the lines to package-manifest.
Comment on attachment 8869747 [details] [diff] [review] Bug1366499.patch Yes, this is what I imagined. I'll leave the review to FRG, he knows more about the issue than I do.
Comment on attachment 8869747 [details] [diff] [review] Bug1366499.patch LGTM and r+ but please take out the whole _setUpUserAgentOverrides from nsSuiteGlue.js and the moodle pref from suite/browser/browser-prefs.js. The moodle pref was added in bug 801318 for SeaMonkey and has been backed out in Fx later. I think it is ancient history. I accessed the site as demo student and it seems to work ok. There is also an indication that it has long ago been fixed in moodle: https://bugzilla.mozilla.org/show_bug.cgi?id=799502#c24 IanN if you don't concur I will put it back in in a followup bug.
Attachment #8869747 - Flags: review?(frgrahl) → review+
Okay, removed the whole _setUpUserAgentOverrides.
Comment on attachment 8869780 [details] [diff] [review] Bug1366499.patch v2 Looks good. Thanks
Attachment #8869780 - Flags: review?(frgrahl) → review+
Fine by me
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.