1366606 - [meta] Build Thunderbird with mozilla-central as topsrcdir

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

This is a meta bug to make mozilla-central the topsrcdir and comm-central a subdirectory. This makes a lot of things easier and various hacks can be removed from mozilla-central and also build automation.

It may also ease the process of using Task Cluster.

Comment 1

[Joshua Cranmer [:jcranmer]]

(In reply to Philipp Kewisch [:Fallen] from comment #0)
> This is a meta bug to make mozilla-central the topsrcdir and comm-central a
> subdirectory. This makes a lot of things easier and various hacks can be
> removed from mozilla-central and also build automation.
> 
> It may also ease the process of using Task Cluster.

One of the biggest challenges in the automation side of things is the fact that we're running multiple repositories which have a fairly close relationship. This is why merging comm-central into mozilla-central was proposed--we'd reduce the number of repositories to 1. Making mozilla-central the topsrcdir and having comm-central be a child repository additionally makes the options for mitigation strategies somewhat worse.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

(In reply to Joshua Cranmer [:jcranmer] from comment #1)
> One of the biggest challenges in the automation side of things is the fact
> that we're running multiple repositories which have a fairly close
> relationship. This is why merging comm-central into mozilla-central was
> proposed--we'd reduce the number of repositories to 1. Making
> mozilla-central the topsrcdir and having comm-central be a child repository
> additionally makes the options for mitigation strategies somewhat worse.

I believe that setting up automation for that would be harder to achieve, therefore I was looking to doing this as an intermediate solution. If we merge them into a common topsrcdir (like the repo you showed me), then it would just be a matter of making moztopsrcdir == commtopsrcdir and possibly remove the distinction afterwards. If we merge them into one repo and keep the subdirectory, this patch could still be useful.

I've had various build failures after clobber locally that were due to the directory mismatch, mach build faster doesn't work without hacks, and the mozilla build system is not really made for an external source dir. Since running this patch locally I've not had problems with build failures like I did before.

Comment 3

[Magnus Melin [:mkmelin]]

This is done (bug 1366607).