1366629 - When clicking on a label attached in Gallery or Photos and Camera to a File Upload field, it no longer works to upload a file.

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P3)

Description

[lgbrowser5]

Attachment: naver_memo.jpg

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; InfoPath.3; NetHelper70; CNS_UA; AD_LOGON=4C47452E4E4554; rv:11.0) like Gecko

Steps to reproduce:

Please see attached image file.
go to naver.com and login.
goto memo and attach file.
Occasional crash while attaching a file.


Actual results:

we can not upload in Gallery ,Photos ,Camera.
We can upload only in Files.
Chrome is normal operating.


Expected results:

File uploads are supported by Firefox browser.

Comment 1

[Jan Henning [:JanH]]

Links to the crashes:
https://crash-stats.mozilla.com/report/index/1c6a64a5-9851-440f-a002-4afa70170521
https://crash-stats.mozilla.com/report/index/5d079935-c416-4cee-ad71-8164c0170521

i.e. some sort of permissions problem.

Interestingly enough, bug 1362919 seems to show sort of the opposite problem - there we request microphone and camera permissions if we don't have them for uploading a file and then don't show even the plain system file picker if those permissions have been denied.

Comment 2

[Mike Kaply [:mkaply]]

So the issue here is not the crash, its that when you attach images via gallery/photos, they simply don't show up in the memo area.

Attaching photos from files works fine.

Comment 3

[Mike Kaply [:mkaply]]

So this works in nightly but fails in beta and mozregression seems to indicate that it always worked, so I'm unclear what broke/and or fixed this.

I really want to find out, though, so I can at least backport it to beta if possible.

Comment 4

[Mike Kaply [:mkaply]]

OK, this is really really strange.

The problem is that on official release builds only, we're not asking for permission.

On anything I build locally, we are properly asking for permission.

If you go to Permission on Firefox, it doesn't have Storage permission. If you give it Storage permission, everything works.

Oddly, our official release Firefox builds have camera permission but no storage whereas anything I built locally has storage but no camera.

I'm throughly confused.

Comment 5

[Mike Kaply [:mkaply]]

Some more info here. On Chrome, they aren't even showing Photos or Documents as choices.

You only have "Camera" and "Files"

So we're giving extra options, but the user doesn't have permission to access those options...

Comment 6

[Mike Kaply [:mkaply]]

Looking at the Chrome code, the big thing we appear to be missing is saving a temporary camera file so the user doesn't have to give storage permission (just camera permission).

And I do not know why we show the other options in the intent (versus just camera and file/documents).

Comment 7

[Mike Kaply [:mkaply]]

OK, I understand a little more.

We're using this for video/image intents to get the URL:

            intent.putExtra(MediaStore.EXTRA_OUTPUT,
                            Uri.fromFile(new File(Environment.getExternalStorageDirectory(),
                                                  fileHandler.generateImageName())));

It requires the external storage directory which means external storage permissions.

So this won't work for the camera.

We should be using a different method.

Comment 8

[Nevin Chen(Not active on Bugzilla)]

I mark it as P2 cause I can't commit the schdule. But it looks important to me.

Comment 9

[Nevin Chen(Not active on Bugzilla)]

Please help prioritize this

Comment 10

[Nevin Chen(Not active on Bugzilla)]

Tested with Nightly 59 and it works. Could you please help verfiy again? Thanks!

Comment 11

[Wesly Huang (EPM)]

lower to P3 before we get more information.

Comment 12

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.