Closed Bug 1366644 Opened 7 years ago Closed 7 years ago

Upgrade Android Gradle plugin to 2.3+

Tracking

(firefox58 fixed)

Status:

RESOLVED FIXED

Milestone:

mozilla58

Tracking Flags:

Tracking

Status

firefox58

---

fixed

People

(Reporter: tyu, Assigned: nalexander)

References

(Blocks 1 open bug)

Details

Attachments

(7 files, 1 obsolete file)

Bug 1366644 - Pre: Bump Gradle JVM heap to allow in-process dex. 7 years ago Nick Alexander :nalexander [he/him] 59 bytes, text/x-review-board-request	maliu : review+	Details
Bug 1366644 - Pre: Work around mach/mozharness/mozprocess output issue. 7 years ago Nick Alexander :nalexander [he/him] 59 bytes, text/x-review-board-request	maliu : review+	Details
Bug 1366644 - Part 1: Avoid deprecated Gradle features. 7 years ago Nick Alexander :nalexander [he/him] 59 bytes, text/x-review-board-request	maliu : review+	Details
Bug 1366644 - Part 2: Work around new deprecation warnings from Android SDK 25/26. 7 years ago Nick Alexander :nalexander [he/him] 59 bytes, text/x-review-board-request	maliu : review+	Details
Bug 1366644 - Part 3a: Update Android build-tools (25.0.3), Gradle (3.4.1), Android-Gradle (2.3.3). 7 years ago Nick Alexander :nalexander [he/him] 59 bytes, text/x-review-board-request	maliu : review+	Details
Bug 1366644 - Pre: Print Android sdkmanager package listing. 7 years ago Nick Alexander :nalexander [he/him] 59 bytes, text/x-review-board-request	maliu : review+	Details
Bug 1366644 - Part 3b: Use lint baseline to broaden Android lint coverage. 7 years ago Nick Alexander :nalexander [he/him] 59 bytes, text/x-review-board-request		Details
Bug 1366644 - Part 3b: Ignore new lint warnings. 7 years ago Nick Alexander :nalexander [he/him] 59 bytes, text/x-review-board-request	maliu : review+	Details

Teng-pao Yu [:tyu]

Reporter

Description

•

7 years ago

With Gradle plugin 2.3 there is lint baseline that may be useful.

For the time being, Android 3.0 is fresh released on the canary channel and so is Android Gradle plugin 3.0.0-alpha1.

So we could might also wait till 3.0 rides on release channel and figure out what the safest versions of Gradle and the Android-Gradle plugin for use with AS 3.0 to avoid duplicate work.

(Originally discussed in Bug 1365878)

Teng-pao Yu [:tyu]

Reporter

Updated

•

7 years ago

Blocks: 1366641

Teng-pao Yu [:tyu]

Reporter

Comment 1

•

7 years ago

2.3 is stable now, seems like 2.3.3 just released yesterday!

    Version: 2.3.3.0
    Release date: June 8, 2017

https://developer.android.com/studio/index.html#downloads

Nick Alexander :nalexander [he/him]

Assignee

Comment 2

•

7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3518c718ba1b

Nick Alexander :nalexander [he/him]

Assignee

Updated

•

7 years ago

Depends on: 1376306

Nick Alexander :nalexander [he/him]

Assignee

Comment 3

•

7 years ago

See also the dependency tree in https://bugzilla.mozilla.org/show_bug.cgi?id=1384312#c0.

Nick Alexander :nalexander [he/him]

Assignee

Comment 4

•

7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d43220e07f1412374ae0d6855d4df37da3f3f034

Nick Alexander :nalexander [he/him]

Assignee

Comment 5

•

7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c5a62884fd2577985dc25585f759bc9249a44f9

Nick Alexander :nalexander [he/him]

Assignee

Comment 6

•

7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6701b950cd9a146166654da76bd82dc601ac61c

Nick Alexander :nalexander [he/him]

Assignee

Comment 7

•

7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28cbfa28b15dbb3c3a8246c948626bb16e1d0b26

Nick Alexander :nalexander [he/him]

Assignee

Comment 8

•

7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3521560b42395c6eaa965d87d71f29afceed29cb

Nick Alexander :nalexander [he/him]

Assignee

Comment 9

•

7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a42366de56a33f1d0126f5e421dca42969c94fe0

Nick Alexander :nalexander [he/him]

Assignee

Comment 10

•

7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5759750b6a1128f84564ea98d38c0a29166a117

Nick Alexander :nalexander [he/him]

Assignee

Comment 11

•

7 years ago

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1305494#c7.

Nick Alexander :nalexander [he/him]

Assignee

Updated

•

7 years ago

Depends on: 1370119

Nick Alexander :nalexander [he/him]

Assignee

Updated

•

7 years ago

Blocks: 1384312

Nick Alexander :nalexander [he/him]

Assignee

Comment 13

•

7 years ago

Just noting here that updating the Android-Gradle build plugin to 2.3.3 requires updating Gradle to 3.3; see https://developer.android.com/studio/releases/gradle-plugin.html.

Nick Alexander :nalexander [he/him]

Assignee

Updated

•

7 years ago

Depends on: 1408479

Comment hidden (mozreview-request)

In-process dex is a slight performance win.

This also upgrades `dexcount-gradle-plugin` to 0.7.1.

Review commit: https://reviewboard.mozilla.org/r/189852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189852/

Comment hidden (mozreview-request)

It's unfortunate, but somehow the

run-task > mozharness > mach build > mach gradle > Gradle

causes Gradle to hang with no output.  We avoid the bug by avoiding
the `max_build_output_timeout > 0` branch in mozharness.  (These tasks
are all in Task Cluster, so they'll be killed eventually and it's not
a huge issue to remove the output timeout.)

Review commit: https://reviewboard.mozilla.org/r/189854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189854/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/189856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189856/

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/189858/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189858/

Comment hidden (mozreview-request)

The goal is to use a newer Android-Gradle build plugin version (2.3.3
is latest stable).  That requires a modern Gradle (anything 3.3+, but
3.4.1 is the default from my Android Studio), and also a newer
build-tools (25.0.3 is latest stable).

The locations of lint output changed, and we want to use the standard
output location because it's difficult to accommodate variant details
in custom names.  We change the location of findbugs output to follow
suit.

Review commit: https://reviewboard.mozilla.org/r/189860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189860/

Max Liu [:maliu]

Comment 19

•

7 years ago

mozreview-review

Comment on attachment 8918963 [details]
Bug 1366644 - Part 3a: Update Android build-tools (25.0.3), Gradle (3.4.1), Android-Gradle (2.3.3).

https://reviewboard.mozilla.org/r/189860/#review195122

::: mobile/android/app/build.gradle:485
(Diff revision 1)
>          excludeFilter = file("findbugs-exclude.xml")
>          dependsOn "assemble${variant.name.capitalize()}"
>  
>          reports {
>              html.enabled = true // HTML reports for humans.
> -            html.destination = "$project.buildDir/outputs/findbugs/findbugs-${variant.name}-output.html"
> +            html.destination = "$project.buildDir/reports/findbugs/findbugs-${variant.name}-output.html"

Looks like we also need to update the output file path in yml file: taskcluster/ci/build/android-stuff.yml

Attachment #8918963 - Flags: review?(max) → review+

Comment hidden (mozreview-request)

This is simply diagnostic; it's nice to see what the versions of the
Android packages installed are, like:

Installed packages:
  Path                              | Version      | Description                       | Location
  -------                           | -------      | -------                           | -------
<snip>
  platforms;android-23              | 3            | Android SDK Platform 23           | platforms/android-23/
  tools                             | 26.0.1       | Android SDK Tools 26.0.1          | tools/

This is really useful because it's not possible to pin most packages
to specific versions; that is, we can only install latest "tools", not
"tools;26.0.1".

Review commit: https://reviewboard.mozilla.org/r/189980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189980/

Comment hidden (mozreview-request)

It's not possible -- or at least not obvious how -- to set the
baseline per variant: see https://stackoverflow.com/q/46561874.  For
now, we'll just set the one baseline for the automation build
(currently `officialPhotonDebug`).

Review commit: https://reviewboard.mozilla.org/r/189982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189982/

Comment hidden (mozreview-request)

Comment on attachment 8918959 [details]
Bug 1366644 - Pre: Bump Gradle JVM heap to allow in-process dex.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189852/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8918960 [details]
Bug 1366644 - Pre: Work around mach/mozharness/mozprocess output issue.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189854/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8918961 [details]
Bug 1366644 - Part 1: Avoid deprecated Gradle features.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189856/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8918962 [details]
Bug 1366644 - Part 2: Work around new deprecation warnings from Android SDK 25/26.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189858/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8918963 [details]
Bug 1366644 - Part 3a: Update Android build-tools (25.0.3), Gradle (3.4.1), Android-Gradle (2.3.3).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189860/diff/1-2/

Max Liu [:maliu]

Comment 27

•

7 years ago

mozreview-review

Comment on attachment 8919071 [details]
Bug 1366644 - Pre: Print Android sdkmanager package listing.

https://reviewboard.mozilla.org/r/189980/#review195258

Attachment #8919071 - Flags: review?(max) → review+

Max Liu [:maliu]

Comment 28

•

7 years ago

mozreview-review

Comment on attachment 8918959 [details]
Bug 1366644 - Pre: Bump Gradle JVM heap to allow in-process dex.

https://reviewboard.mozilla.org/r/189852/#review195260

Attachment #8918959 - Flags: review?(max) → review+

Max Liu [:maliu]

Comment 29

•

7 years ago

mozreview-review

Comment on attachment 8918960 [details]
Bug 1366644 - Pre: Work around mach/mozharness/mozprocess output issue.

https://reviewboard.mozilla.org/r/189854/#review195262

Attachment #8918960 - Flags: review?(max) → review+

Max Liu [:maliu]

Comment 30

•

7 years ago

mozreview-review

Comment on attachment 8918961 [details]
Bug 1366644 - Part 1: Avoid deprecated Gradle features.

https://reviewboard.mozilla.org/r/189856/#review195264

Attachment #8918961 - Flags: review?(max) → review+

Max Liu [:maliu]

Comment 31

•

7 years ago

mozreview-review

Comment on attachment 8918962 [details]
Bug 1366644 - Part 2: Work around new deprecation warnings from Android SDK 25/26.

https://reviewboard.mozilla.org/r/189858/#review195124

We also need to lint

Attachment #8918962 - Flags: review?(max) → review+

Max Liu [:maliu]

Comment 32

•

7 years ago

mozreview-review

Comment on attachment 8919072 [details]
Bug 1366644 - Part 3b: Use lint baseline to broaden Android lint coverage.

https://reviewboard.mozilla.org/r/189982/#review195266

::: mobile/android/app/lint-baseline.xml:10
(Diff revision 1)
> +        id="MissingPermission"
> +        message="Missing permissions required by KeyguardManager.KeyguardLock.disableKeyguard: android.permission.DISABLE_KEYGUARD"
> +        errorLine1="                keyguardLock.disableKeyguard();"
> +        errorLine2="                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
> +        <location
> +            file="/Users/nalexander/Mozilla/gecko/mobile/android/tests/browser/robocop/src/org/mozilla/gecko/FennecInstrumentationTestRunner.java"

We may have to replace abspath to wildcard filepath

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/190328/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190328/

Comment hidden (mozreview-request)

Comment on attachment 8919071 [details]
Bug 1366644 - Pre: Print Android sdkmanager package listing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189980/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8918959 [details]
Bug 1366644 - Pre: Bump Gradle JVM heap to allow in-process dex.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189852/diff/2-3/

Comment hidden (mozreview-request)

Comment on attachment 8918960 [details]
Bug 1366644 - Pre: Work around mach/mozharness/mozprocess output issue.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189854/diff/2-3/

Comment hidden (mozreview-request)

Comment on attachment 8918961 [details]
Bug 1366644 - Part 1: Avoid deprecated Gradle features.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189856/diff/2-3/

Comment hidden (mozreview-request)

Comment on attachment 8918962 [details]
Bug 1366644 - Part 2: Work around new deprecation warnings from Android SDK 25/26.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189858/diff/2-3/

Comment hidden (mozreview-request)

Comment on attachment 8918963 [details]
Bug 1366644 - Part 3a: Update Android build-tools (25.0.3), Gradle (3.4.1), Android-Gradle (2.3.3).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189860/diff/2-3/

Nick Alexander :nalexander [he/him]

Assignee

Updated

•

7 years ago

Attachment #8919072 - Attachment is obsolete: true

Attachment #8919072 - Flags: review?(max)

Max Liu [:maliu]

Comment 40

•

7 years ago

mozreview-review

Comment on attachment 8919482 [details]
Bug 1366644 - Part 3b: Ignore new lint warnings.

https://reviewboard.mozilla.org/r/190328/#review195606

Attachment #8919482 - Flags: review?(max) → review+

Nick Alexander :nalexander [he/him]

Assignee

Updated

•

7 years ago

Assignee: nobody → nalexander

Status: NEW → ASSIGNED

Pulsebot

Comment 41

•

7 years ago

Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff11e283b905
Pre: Print Android sdkmanager package listing. r=maliu
https://hg.mozilla.org/integration/autoland/rev/fff0a54320b0
Pre: Bump Gradle JVM heap to allow in-process dex. r=maliu
https://hg.mozilla.org/integration/autoland/rev/1a0e10b4ea13
Pre: Work around mach/mozharness/mozprocess output issue. r=maliu
https://hg.mozilla.org/integration/autoland/rev/ba0e40a0b33f
Part 1: Avoid deprecated Gradle features. r=maliu
https://hg.mozilla.org/integration/autoland/rev/ea8854aacc68
Part 2: Work around new deprecation warnings from Android SDK 25/26. r=maliu
https://hg.mozilla.org/integration/autoland/rev/1c49a7a7cb5e
Part 3a: Update Android build-tools (25.0.3), Gradle (3.4.1), Android-Gradle (2.3.3). r=maliu
https://hg.mozilla.org/integration/autoland/rev/15f9515982b7
Part 3b: Ignore new lint warnings. r=maliu

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 42

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ff11e283b905
https://hg.mozilla.org/mozilla-central/rev/fff0a54320b0
https://hg.mozilla.org/mozilla-central/rev/1a0e10b4ea13
https://hg.mozilla.org/mozilla-central/rev/ba0e40a0b33f
https://hg.mozilla.org/mozilla-central/rev/ea8854aacc68
https://hg.mozilla.org/mozilla-central/rev/1c49a7a7cb5e
https://hg.mozilla.org/mozilla-central/rev/15f9515982b7

Status: ASSIGNED → RESOLVED

Closed: 7 years ago

status-firefox58: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 58

Nick Alexander :nalexander [he/him]

Assignee

Updated

•

7 years ago

Blocks: 1413006

Nick Alexander :nalexander [he/him]

Assignee

Updated

•

7 years ago

Blocks: 1415298

BMO Automation

Updated

•

5 years ago

Product: Firefox for Android → Firefox Build System

Target Milestone: Firefox 58 → mozilla58

You need to log in before you can comment on or make changes to this bug.