Closed Bug 1366664 Opened 5 years ago Closed 5 years ago

(photon) (baseline) New onboarding experience to reflect the new look

Categories

(Firefox for Android Graveyard :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: wesley_huang, Assigned: cnevinchen)

References

Details

(Whiteboard: [FNC][SPT57.2][MVP][SP=X, 8])

Attachments

(7 files, 1 obsolete file)

No description provided.
waiting for UX input
Assignee: nobody → cnevinchen
Comment on attachment 8892386 [details]
Bug 1366664 - Remove onboarding experiments after phonton 57.

https://reviewboard.mozilla.org/r/163330/#review170178

::: mobile/android/base/locales/en-US/android_strings.dtd:5
(Diff revision 3)
>  <!-- This Source Code Form is subject to the terms of the Mozilla Public
>     - License, v. 2.0. If a copy of the MPL was not distributed with this
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  
> -<!ENTITY firstrun_panel_title_welcome "Welcome">
> +<!ENTITY firstrun_panel_title_welcome "WELCOME">

is this necessary or we can use `android:textAllCaps`? (same as PRIVACY, SYNC, NEXT....etc)
Whiteboard: [FNC][SPT#57.1][MVP]
Whiteboard: [FNC][SPT#57.1][MVP] → [FNC][SPT57.1][MVP]
Comment on attachment 8892386 [details]
Bug 1366664 - Remove onboarding experiments after phonton 57.

https://reviewboard.mozilla.org/r/163330/#review171572
Attachment #8892386 - Flags: review?(walkingice0204) → review+
Comment on attachment 8894457 [details]
Bug 1366664 - Update UI for onboarding after phonton 57.

https://reviewboard.mozilla.org/r/165584/#review171574

::: mobile/android/app/src/main/res/layout/firstrun_sync_fragment.xml:55
(Diff revision 1)
>  
>          <View android:layout_weight="1"
>                android:layout_height="0dp"
>                android:layout_width="match_parent"/>
>  
>          <TextView android:id="@+id/welcome_browse"

I am not sure, maybe this id resource is not necessary since there is firstrun_subtext?

::: mobile/android/base/locales/en-US/android_strings.dtd:25
(Diff revision 1)
>  <!ENTITY firstrun_sync_title "Sync">
> -<!ENTITY firstrun_sync_message "&brandShortName;, always by your side">
> -<!ENTITY firstrun_sync_subtext "Sync your tabs, passwords, and more everywhere you use it.">
> +<!ENTITY firstrun_sync_message2 "Pick up where you left off.">
> +<!ENTITY firstrun_sync_subtext2 "Use Sync to find the bookmarks, passwords, and other things you save to Firefox on all your devices.">
>  <!ENTITY firstrun_signin_message "Get connected, get started">
>  <!ENTITY firstrun_signin_button "Sign in to Sync">
> -<!ENTITY  onboard_start_button_browser "Start Browsing">
> +<!ENTITY  onboard_start_button_browser "START BROWSING">

is this necessary or we can use `android:textAllCaps`? (same as NEXT)
Attachment #8894457 - Flags: review?(walkingice0204) → review+
Comment on attachment 8894458 [details]
Bug 1366664 - If the user has alread signed-in, we show only three first-run panel.

https://reviewboard.mozilla.org/r/165636/#review171576

::: mobile/android/base/java/org/mozilla/gecko/firstrun/LastPanel.java:23
(Diff revision 1)
> +
> +public class LastPanel extends FirstrunPanel {
> +    @Override
> +    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstance) {
> +        final ViewGroup root = (ViewGroup) inflater.inflate(R.layout.firstrun_basepanel_checkable_fragment, container, false);
> +        Bundle args = getArguments();

nit: final
Attachment #8894458 - Flags: review?(walkingice0204) → review+
Comment on attachment 8894459 [details]
Bug 1366664 - Remove unused resource to make lint happy.

https://reviewboard.mozilla.org/r/165638/#review171578
Attachment #8894459 - Flags: review?(walkingice0204) → review+
Comment on attachment 8895310 [details]
Bug 1366664t - Update color and layout. Hide splash screen if first seen.

https://reviewboard.mozilla.org/r/166510/#review172194
Attachment #8895310 - Flags: review?(walkingice0204) → review+
QA Contact: ioana.chiorean
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a21eb146fba
Remove onboarding experiments after phonton 57. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/51868598947e
Update UI for onboarding after phonton 57. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/014d0def1489
If the user has alread signed-in, we show only three first-run panel. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/e078166d9857
Remove unused resource to make lint happy. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/e5dfbde553d6
Update color and layout. Hide splash screen if first seen. r=walkingice
Whiteboard: [FNC][SPT57.1][MVP] → [FNC][SPT57.2][MVP]
Comment on attachment 8894457 [details]
Bug 1366664 - Update UI for onboarding after phonton 57.

https://reviewboard.mozilla.org/r/165584/#review174464

::: mobile/android/base/locales/en-US/android_strings.dtd:12
(Diff revision 4)
> -<!ENTITY firstrun_urlbar_message "Welcome to &brandShortName;">
> -<!ENTITY firstrun_urlbar_subtext "Find things faster with helpful search suggestion shortcuts.">
> +<!ENTITY firstrun_urlbar_subtext2 "A modern mobile browser from Mozilla, the non-profit committed to a free and open web.">
> +<!ENTITY firstrun_panel_title_privacy "Privacy">
> +<!ENTITY firstrun_privacy_message "Browse like no one\'s watching">
> +<!ENTITY firstrun_privacy_subtext "Private Browsing with Tracking Protection blocks trackers while you browse and won’t remember your history when you finish browsing.">
> +<!ENTITY firstrun_panel_title_customize "Customize">
> +<!ENTITY firstrun_customize_message "Make Firefox your own.">

Firefox should never be hard-coded in strings, there's &brandShortName; for a reason.

::: mobile/android/base/locales/en-US/android_strings.dtd:13
(Diff revision 4)
> -<!ENTITY firstrun_urlbar_subtext "Find things faster with helpful search suggestion shortcuts.">
> +<!ENTITY firstrun_panel_title_privacy "Privacy">
> +<!ENTITY firstrun_privacy_message "Browse like no one\'s watching">
> +<!ENTITY firstrun_privacy_subtext "Private Browsing with Tracking Protection blocks trackers while you browse and won’t remember your history when you finish browsing.">
> +<!ENTITY firstrun_panel_title_customize "Customize">
> +<!ENTITY firstrun_customize_message "Make Firefox your own.">
> +<!ENTITY firstrun_customize_subtext "Customize Firefox with add-ons. Block ads, add features, or choose a new theme to reflect your personality.">

Same here

::: mobile/android/base/locales/en-US/android_strings.dtd:22
(Diff revision 4)
>  <!ENTITY firstrun_data_title "Data">
>  <!ENTITY firstrun_data_message "Less data, more savings">
>  <!ENTITY firstrun_data_subtext2 "Turn off images to spend less data on every site you visit.">
>  <!ENTITY firstrun_sync_title "Sync">
> -<!ENTITY firstrun_sync_message "&brandShortName;, always by your side">
> -<!ENTITY firstrun_sync_subtext "Sync your tabs, passwords, and more everywhere you use it.">
> +<!ENTITY firstrun_sync_message2 "Pick up where you left off.">
> +<!ENTITY firstrun_sync_subtext2 "Use Sync to find the bookmarks, passwords, and other things you save to Firefox on all your devices.">

Same here
This bug either needs a back-out or a quick follow-up to fix those strings.

Also note: https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Can we please make a note to check for these errors? It keeps happening on Android (twice in the two last landings).
Flags: needinfo?(walkingice0204)
Flags: needinfo?(cnevinchen)
Blocks: 1390950
I've add bug 1390950 to fix this.
No longer blocks: 1390950
Flags: needinfo?(cnevinchen)
Backed out for the string issues mentioned by flod.

https://hg.mozilla.org/mozilla-central/rev/833f84d0d5c729054a3aa8b3f34735f56fe6436b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 57 → ---
Comment on attachment 8898199 [details]
Bug 1366664 - Update brand name string

I added this patch for comment 32
(In reply to Francesco Lodolo [:flod] (traveling, slow reply until Aug 18) from comment #33)
> This bug either needs a back-out or a quick follow-up to fix those strings.
> 
> Also note:
> https://developer.mozilla.org/en-US/docs/Mozilla/Localization/
> Localization_content_best_practices#Changing_existing_strings
> 
> Can we please make a note to check for these errors? It keeps happening on
> Android (twice in the two last landings).

I've added to our team's note. Sorry and thank you!
Please review this patch. It contains old icon. Can I land this now?
Flags: needinfo?(chuang)
Flags: needinfo?(bmao)
Comment on attachment 8898199 [details]
Bug 1366664 - Update brand name string

https://reviewboard.mozilla.org/r/169562/#review175168
Attachment #8898199 - Flags: review?(walkingice0204) → review+
(In reply to Nevin Chen [:nechen] from comment #48)
> Please review this patch. It contains old icon. Can I land this now?

Like discussed with Product we are ok to land w/o the logo, just need to have a follow-up bug link to it for the future update, would you help on it? Thanks.
Attachment #8898198 - Attachment is obsolete: true
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d84aa209917d
Remove onboarding experiments after phonton 57. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/aeff247e7e51
Update UI for onboarding after phonton 57. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/aa01bbb30ff9
If the user has alread signed-in, we show only three first-run panel. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/1dc8da532bd7
Remove unused resource to make lint happy. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/0165837e1ae9
Update brand name string r=walkingice
Flags: needinfo?(walkingice0204)
https://hg.mozilla.org/mozilla-central/rev/6a94424d7971
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
6a94424d7971 has a 't' on the end of the bug number, thus the lack of pulsebot comment and the separate bugherder comment.
It looks like this added 100KB or so to the installer size.  Was this an expected result?
Flags: needinfo?(cnevinchen)
Hi Peko! 
Please review the New Onboarding UI and see if it's good. Thanks!!
Flags: needinfo?(chuang) → needinfo?(pchen)
Hi Nathan
Yes. We removed 84K of images and added 181K of new images. So this is expected( we'll land some more)

Hi Carol
Could we make these images size smaller?
Flags: needinfo?(cnevinchen) → needinfo?(chuang)
Attached file _Assets_resize.zip
Hi Nevin

Please see attached file for re-sized images and see is it ok for you.
Thanks~
Flags: needinfo?(pchen)
Peko will help solving this issue. thanks!
Flags: needinfo?(chuang)
Whiteboard: [FNC][SPT57.2][MVP] → [FNC][SPT57.2][MVP][SP=X, 8]
(In reply to Peko Chen [:pekochen] from comment #62)
> Created attachment 8900071 [details]
> _Assets_resize.zip
> 
> Hi Nevin
> 
> Please see attached file for re-sized images and see is it ok for you.
> Thanks~

Do we need to update the images?
Flags: needinfo?(bmao) → needinfo?(cnevinchen)
I think Joe will let us know when the time to come?
Flags: needinfo?(cnevinchen)
Blocks: 1396741
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.