Update cubeb from upstream to 96cdb17

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: cubeb
P1
normal
Rank:
15
RESOLVED FIXED
9 months ago
5 months ago

People

(Reporter: achronop, Assigned: achronop)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

9 months ago
Pick commits:

96cdb17 Dan Glastonbury Push destroy fns to backend (#302)
91f801d Michael Maltese CMake: allow googletest and sanitizers-cmake from parent projects
32fcb3a Matthew Gregan  Report more missing git submodules (follow up to 978788a0).
b44f582 Dan Glastonbury Enable ASAN for clang
ad8ff2a Dan Glastonbury Fix memory leaks in tests.
033b736 Dan Glastonbury Setup CMake to compile with Clang/GCC sanitizers.
ac8496d Chun-Min Chang  wasapi: Fix handle_channel_layout for input stream (#301)
7a4c711 Alex Chronopoulos       audiounit: synchronize destroy stream and reinit (Bug 1361657)
978788a Matthew Gregan  Report missing git submodules from CMake.
dd746a3 Alex Chronopoulos       audiounit: don't reinit stream on datasource event
1284f96 Alex Chronopoulos       audiounit: on reinit check volume if stream has output
26a50b0 Chun-Min Chang  Do not mix audio when no frames come
45c7ffc Paul Adenot     Return an error if stopping a WASAPI stream fails.
4bf03c2 Alex Chronopoulos       audiounit: Stop re-register system listeners on reinit to avoid deadlock
d43753e Chun-Min Chang  Use same mixer interface for wasapi and audiounit (#290)
fe23983 Chun-Min Chang  wasapi: Fix crash while switching device (#292)
(Assignee)

Comment 1

9 months ago
Please add your bugs.
Blocks: 1361657
Rank: 15
Priority: -- → P1
(Assignee)

Updated

9 months ago
Blocks: 1358868
(Assignee)

Comment 2

9 months ago
Wrong list of commits:

96cdb17 Dan Glastonbury Push destroy fns to backend (#302)
91f801d Michael Maltese CMake: allow googletest and sanitizers-cmake from parent projects
32fcb3a Matthew Gregan  Report more missing git submodules (follow up to 978788a0).
b44f582 Dan Glastonbury Enable ASAN for clang
ad8ff2a Dan Glastonbury Fix memory leaks in tests.
033b736 Dan Glastonbury Setup CMake to compile with Clang/GCC sanitizers.
ac8496d Chun-Min Chang  wasapi: Fix handle_channel_layout for input stream (#301)
7a4c711 Alex Chronopoulos       audiounit: synchronize destroy stream and reinit (Bug 1361657)
978788a Matthew Gregan  Report missing git submodules from CMake.
dd746a3 Alex Chronopoulos       audiounit: don't reinit stream on datasource event
1284f96 Alex Chronopoulos       audiounit: on reinit check volume if stream has output
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8870032 [details]
Bug 1366707 - update callers of cubeb_device_collection_destroy.

https://reviewboard.mozilla.org/r/141552/#review145268

::: media/libcubeb/src/moz.build:16
(Diff revision 2)
>  SOURCES += [
>      'cubeb.c',
>      'cubeb_log.cpp',
>      'cubeb_mixer.cpp',
> -    'cubeb_panner.cpp'
> +    'cubeb_panner.cpp',
> +    'cubeb_utils.c'

This should be in the other patch.
Attachment #8870032 - Flags: review?(kinetik) → review+
Comment on attachment 8869968 [details]
Bug 1366707 - Update cubeb from upstream to 96cdb17.

https://reviewboard.mozilla.org/r/141518/#review145272
Attachment #8869968 - Flags: review?(kinetik) → review+
(Assignee)

Updated

9 months ago
Assignee: nobody → achronop
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 15

9 months ago
Pushed by achronop@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9024a001f962
Update cubeb from upstream to 96cdb17. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/39cc9ca51737
update callers of cubeb_device_collection_destroy. r=kinetik

Comment 16

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9024a001f962
https://hg.mozilla.org/mozilla-central/rev/39cc9ca51737
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1359477
You need to log in before you can comment on or make changes to this bug.