1366720 - ESLint simpletest and places-overlay environments don't list globals correctly when used outside of mozilla-central

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

When using eslint-plugin-mozilla outside of mozilla-central, I noticed that we're not correctly exporting globals from the simpletest and places-overlay environments.

The export currently ends up as:

module.exports = {
  globals: {
    globals: {
      ...
    }
  }
};

rather than:

module.exports = {
  globals: {
    ...
  }
};

The fix is simple, I'll get a patch up for this.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1366720 - ESLint simpletest and places-overlay environments don't export globals correctly when used outside of mozilla-central.

Review commit: https://reviewboard.mozilla.org/r/141532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141532/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8869980 [details]
Bug 1366720 - ESLint simpletest and places-overlay environments don't export globals correctly when used outside of mozilla-central.

https://reviewboard.mozilla.org/r/141532/#review145252

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3972fd69323
ESLint simpletest and places-overlay environments don't export globals correctly when used outside of mozilla-central. r=mossop

Comment 4

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1366720 - ESLint simpletest and places-overlay environments don't export globals correctly when used outside of mozilla-central.

Review commit: https://reviewboard.mozilla.org/r/141630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141630/

Comment 5

[Dave Townsend [:mossop]]

(In reply to Manish Goregaokar [:manishearth] from comment #4)
> Created attachment 8870182 [details]
> Bug 1366720 - ESLint simpletest and places-overlay environments don't export
> globals correctly when used outside of mozilla-central.
> 
> Review commit: https://reviewboard.mozilla.org/r/141630/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/141630/

What is this? I looks like the same patch I already reviewed and has been landed.

Comment 6

[Manish Goregaokar [:manishearth]]

Comment on attachment 8870182 [details]
Bug 1366720 - ESLint simpletest and places-overlay environments don't export globals correctly when used outside of mozilla-central.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141630/diff/1-2/

Comment 7

[Manish Goregaokar [:manishearth]]

Oh, ran mozerview push in the wrong directory *Facepalm*.

sorry.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d3972fd69323