Closed Bug 1366720 Opened 3 years ago Closed 3 years ago

ESLint simpletest and places-overlay environments don't list globals correctly when used outside of mozilla-central

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

3 Branch
enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file, 1 obsolete file)

When using eslint-plugin-mozilla outside of mozilla-central, I noticed that we're not correctly exporting globals from the simpletest and places-overlay environments.

The export currently ends up as:

module.exports = {
  globals: {
    globals: {
      ...
    }
  }
};

rather than:

module.exports = {
  globals: {
    ...
  }
};

The fix is simple, I'll get a patch up for this.
Comment on attachment 8869980 [details]
Bug 1366720 - ESLint simpletest and places-overlay environments don't export globals correctly when used outside of mozilla-central.

https://reviewboard.mozilla.org/r/141532/#review145252
Attachment #8869980 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3972fd69323
ESLint simpletest and places-overlay environments don't export globals correctly when used outside of mozilla-central. r=mossop
(In reply to Manish Goregaokar [:manishearth] from comment #4)
> Created attachment 8870182 [details]
> Bug 1366720 - ESLint simpletest and places-overlay environments don't export
> globals correctly when used outside of mozilla-central.
> 
> Review commit: https://reviewboard.mozilla.org/r/141630/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/141630/

What is this? I looks like the same patch I already reviewed and has been landed.
Flags: needinfo?(manishearth)
Attachment #8870182 - Flags: review?(dtownsend)
Oh, ran mozerview push in the wrong directory *Facepalm*.

sorry.
Flags: needinfo?(manishearth)
Attachment #8870182 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/d3972fd69323
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.