136673 - add version information to mozilla.exe

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Jon Granrose]

This is an offshoot of 23560.  mozilla.exe needs version information in the file
properties.

Comment 1

[Aki Sasaki]

Attachment: adds RCINCLUDE functionality and modifies xpfe/bootstrap makefiles to take advantage and autoversion mozilla.exe

Comment 2

[Aki Sasaki]

This patch also fixes the nmake versioning... -TOPSRCDIR $(topsrcdir) changed to
-TOPSRCDIR $(DEPTH) in version.inc since topsrcdir isn't set in nmake builds.

This is breaking autoversioning in all nmake mozilla builds since -OFFICIAL 1 is
after the -TOPSRCDIR bit, and the missing argument horked the rest of the
command line... everything's permanently set to 0.0.0.0 without this patch
(which I knew of for a while, but thought would only be a temporary cosmetic
problem).

Looking for r=/sr=

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 79315 [details] [diff] [review]
adds RCINCLUDE functionality and modifies xpfe/bootstrap makefiles to take advantage and autoversion mozilla.exe

r=cls

Comment 4

[Daniel (Leaf) Nunes]

Comment on attachment 79315 [details] [diff] [review]
adds RCINCLUDE functionality and modifies xpfe/bootstrap makefiles to take advantage and autoversion mozilla.exe

with the caveat that the origin call change be removed, sr=leaf
(marking a=, as well, for build/config blanket)

Comment 5

[Aki Sasaki]

Attachment: updated version.inc

removes the origin bit, fixes the fix to the topsrcdir bit since my evening
build had a problem with the backslash.

Comment 6

[Aki Sasaki]

leaf checked this into the branch...

Comment 7

[Aki Sasaki]

this appears to be working on the trunk as well. closing.

Comment 8

[:deanis74]

I don't see the version info tab on the mozilla.exe from today's build.  Re-
opening.

Comment 9

[:deanis74]

It looks like this was never checked in to the trunk.

Comment 10

[Aki Sasaki]

Attachment: trunk patch, with module.ver and updated milestone.txt

Trunk patch...

Comment 11

[Stephen Walker]

*** Bug 162606 has been marked as a duplicate of this bug. ***

Comment 12

[Aki Sasaki]

Attachment: new trunk patch...

the new patch is diffed against today's source, and removes the nmake
functionality since that's not around anymore...

Comment 13

[Aki Sasaki]

cls, leaf, could i get an r=/sr= for the trunk?

this patch also fixes bug 138764.

Comment 14

[hacker formerly known as [e-mail]]

Comment on attachment 95915 [details] [diff] [review]
new trunk patch...

r=cls

Comment 15

[Aki Sasaki]

checked into the trunk.

Comment 16

[:deanis74]

Verified fixed using 2002082508.  Properties for mozilla.exe has a Version tab.