1366770 - Custom Tab: Toolbar still displayed if a video is fullscreen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Huawei Honor (Android 5.1.1);
Build: Nightly 55.0a1 (2017-05-22);

Steps to reproduce:
1. Open https://www.w3schools.com/html/html5_video.asp in custom tab;
2. Tap full screen button and play the video.

Expected result:
The video enters full-screen and no visible issues are displayed.

Actual result:
The video enters full screen but the toolbar is still displayed.

Comment 1

[Julian Chu [:walkingice]]

note: I see there is a callback for Fullscreen in GeckoView[1]. Maybe we can use this callback once CusttomTabs involves GeckoView.

Jim, is my assumption for the callback correct? or the callback is for another purpose? Thanks!

[1] https://dxr.mozilla.org/mozilla-central/rev/f9ca97a334296facd2e0ea5582e7f12d0fe70fe4/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java#1128

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Yes, `onFullScreen` is called when Gecko is requesting full screen mode, and the app should implement `onFullScreen` to make the whole activity go full screen.

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

per the discussion with Joe and Julian, this is P2 bug we could fix in the later phase.

Comment 4

[Dylan Roeh (:droeh) (he/him)]

Attachment: Implement onFullScreen for custom tabs

This is a simple fix.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8895370 [details] [diff] [review]
Implement onFullScreen for custom tabs

Review of attachment 8895370 [details] [diff] [review]:
-----------------------------------------------------------------

I think you should use ActivityUtils.setFullScreen(), as that has some additional considerations for various OS versions

Comment 6

[Dylan Roeh (:droeh) (he/him)]

Attachment: Implement onFullScreen for custom tabs

Ah, good point.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66d4f2c88db7
Implement ContentListener.onFullScreen() for custom tabs. r=snorp

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/66d4f2c88db7

Comment 9

[Sorina Florean [:sflorean]]

Verified as fixed in build 57.0a1 2017-08-28;
Device: Asus ZenPad 8 (Android 6.0.1).
When the video enters full screen, the toolbar is not displayed.