"original filename" is empty in version info

RESOLVED FIXED in mozilla1.2beta

Status

SeaMonkey
Build Config
P3
minor
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: Henrik Gemal, Assigned: Aki Sasaki)

Tracking

Trunk
mozilla1.2beta
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

541 bytes, patch
hacker formerly known as seawood@netscape.com
: review+
Details | Diff | Splinter Review
1.69 KB, patch
hacker formerly known as seawood@netscape.com
: review+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
version information in the file properties is at the best bad:

- "fileversion" on files (fx ISimpleDOMDocumentMarshal.dll) are 0.0.0.0
- "description" is empty
- "Company name" should be "Mozilla.org" not "Mozilla"
- "Legal trademark" should perhaps mention MPL, etc
- "Original filename" is empty
-> aki
Assignee: seawood → asasaki
(Assignee)

Comment 2

16 years ago
0.0.0.0 becomes something else when:

1) config/milestone.txt is x.x.x or x.x.x.x (-not- x.x.x+)
2) BUILD_OFFICIAL and/or MOZILLA_OFFICIAL are set.

The other stuff is cosmetic for the most part, so wasn't as urgent to get in. 
Should all be tweakable in config/version_win.pl, which I'll take a look at when
I have time.

Updated

16 years ago
Severity: normal → minor
Priority: -- → P3
Target Milestone: --- → mozilla1.2beta
(Assignee)

Comment 3

16 years ago
1) is intentional
2) is taken care of in bug 138764
3) marking wontfix...
4) marking wontfix...

changing summary to "original filename is empty"
Status: NEW → ASSIGNED
Summary: most of versioninfo is bugus or missing → "original filename" is empty in version info
(Assignee)

Comment 4

16 years ago
Created attachment 89480 [details] [diff] [review]
mozilla patch for original filename
(Assignee)

Comment 5

16 years ago
Created attachment 99553 [details] [diff] [review]
updated mozilla trunk patch
Attachment #89480 - Attachment is obsolete: true
(Assignee)

Comment 6

16 years ago
Created attachment 99555 [details] [diff] [review]
commercial trunk patch

wasn't sure if i should nuke version.inc or patch it... this has the patch.
(Assignee)

Comment 7

16 years ago
got original filename working.  cls, could i get r=?
Whiteboard: need r
Comment on attachment 99553 [details] [diff] [review]
updated mozilla trunk patch

r=cls
Attachment #99553 - Flags: review+
Comment on attachment 99555 [details] [diff] [review]
commercial trunk patch

r=cls
Attachment #99555 - Flags: review+
(Assignee)

Comment 10

16 years ago
checked into the trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Whiteboard: need r
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.