Invalid webRequest.ResourceType value "object_subrequest"

RESOLVED FIXED in Firefox 55

Status

P3
normal
RESOLVED FIXED
2 years ago
6 months ago

People

(Reporter: vlpast, Assigned: mixedpuppy)

Tracking

53 Branch
mozilla55

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170518000419

Steps to reproduce:

Tested on Firefox 53.0.3 (64-bit) with Adobe Flash player 25.0.0.171, Windows 7.

1) Add test event listener:

chrome.webRequest.onBeforeSendHeaders.addListener(console.log, { urls: ['*://*/*'] });

2) Open a page containing Flash media player

https://www.becomeabettertrader.com/category/free-daily-videos/

3) Click Play button



Actual results:

Several requests with type "object_subrequest" are logged:

Object { requestId: "143", url: "https://bbtnightlynewsletters.s3.amazonaws.com/robsfree/05-23-2017-Free.mp4", originUrl: "https://www.becomeabettertrader.com…", method: "GET", tabId: 1, type: "object_subrequest", timeStamp: 1495480315146, frameId: 0, parentFrameId: -1 }


Expected results:

Type should be set to a valid resource type such as "media" (as in Google Chrome for this particular request), or "other", according to ResourceType specification:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webRequest/ResourceType

Also, an attempt to add filter by type "object_subrequest"

chrome.webRequest.onBeforeSendHeaders.addListener(console.log, { urls: ['*://*/*'], types: ['object_subrequest'] });

fails with

Error: Type error for parameter filter (Error processing types.0: Invalid enumeration value "object_subrequest") for webRequest.onBeforeSendHeaders.
Component: Untriaged → WebExtensions: Request Handling
Product: Firefox → Toolkit
(Assignee)

Updated

2 years ago
Flags: needinfo?(mixedpuppy)
(Assignee)

Comment 1

2 years ago
Since:

- we could only change "object_subrequest" to "other"
- object_subrequest is for requests made by plugins (ie flash)
- changing to "other" would not identify plugin requests

I'm going to add object_subrequest as a type.  In the future when all plugins are dead, we can remove it.
Assignee: nobody → mixedpuppy
Flags: needinfo?(mixedpuppy)
Priority: -- → P3
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8872413 [details]
Bug 1366862 add object_subrequest to types,

https://reviewboard.mozilla.org/r/143922/#review148460
Attachment #8872413 - Flags: review?(aswan) → review+

Comment 4

2 years ago
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b555966eb1bb
add object_subrequest to types, r=aswan

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b555966eb1bb
Status: UNCONFIRMED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

6 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.