Closed
Bug 1366869
Opened 5 years ago
Closed 5 years ago
Make DISPATCH_NORMAL be the default flags argument for nsIEventTarget::Dispatch
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(1 file)
14.12 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
I'm trying to make nsIEventTarget easier to use, and the requirement that you pass flags in is pretty annoying. This patch changes XPIDL to allow default parameter values to be specified (as long as they're identifiers). I also added a new #define, NS_DECL_NSIEVENTTARGET_FULL, that does "using nsIEventTarget::Dispatch;". Originally this was more useful when I was trying to make this patch work in a different way. Now it's just a slight simplification. i can remove it if you like.
Attachment #8870132 -
Flags: review?(nfroyd)
![]() |
||
Comment 1•5 years ago
|
||
Comment on attachment 8870132 [details] [diff] [review] patch Review of attachment 8870132 [details] [diff] [review]: ----------------------------------------------------------------- This seems like a nice cleanup, thank you.
Attachment #8870132 -
Flags: review?(nfroyd) → review+
Pushed by wmccloskey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7affc8fb26 Make DISPATCH_NORMAL be the default flags argument for nsIEventTarget::Dispatch (r=froydnj)
Comment 3•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9b7affc8fb26
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•