1366886 - GetLangGroup should be consistent

Status: RESOLVED DUPLICATE of bug 734008

(Core :: Graphics: Text, defect)

Description

[Manish Goregaokar [:manishearth]]

As mentioned in bug 136259 comment 12, GetLangGroup returns different results for unknown languages based on when it gets called.

Changing it to be infallible so that this no longer happens.

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1366886 - Make GetLanguageGroup infallible so that it always returns the same result;

Review commit: https://reviewboard.mozilla.org/r/141616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141616/

Comment 2

[Jonathan Kew [:jfkthame]]

I've just posted an updated patch for review in bug 734008 that would have this effect, so if we can get that reviewed and landed promptly, this will be redundant.

(But if that looks like being slow, we can potentially do this in the meantime.)

Comment 3

[Manish Goregaokar [:manishearth]]

WFM.