Closed Bug 1366907 Opened 2 years ago Closed 2 years ago

Remove BufferDecoder's GMPCrashHelper

Categories

(Core :: Web Audio, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

Details

Attachments

(1 file)

We no longer support use of GMPs for decoding of non-EME content. So we can remove the GMPCrashHelper from the WebAudio BufferDecoder class, since we can't be using GMPs here.

This was added in bug 1267918.
Why no support for GMP? Since when?

I need this for webrtc use of MediaDataDecoder with OpenH264
I think the relevant portion here is "from the WebAudio BufferDecoder class" - so this is probably fine.

Chris: can you clarify?  OpenH264 is non-EME, and we've talked about moving things like VC1 decoding (and encoding once we do that) into a GMP process for security reasons, especially for interactive use.
Flags: needinfo?(cpearce)
(In reply to Jean-Yves Avenard [:jya] from comment #2)
> Why no support for GMP? Since when?

When we removed Adobe's GMP in January, we lost the only GMP that had any useful audio decoders, so I removed the GMP audio decoding path.

> I need this for webrtc use of MediaDataDecoder with OpenH264

The code I'm removing is only called by AudioContent.decodeAudioData(). WebRTC and OpenH264 are not involved here at all.
(In reply to Randell Jesup [:jesup] from comment #3)
> I think the relevant portion here is "from the WebAudio BufferDecoder class"
> - so this is probably fine.

Exactly.

> Chris: can you clarify?  OpenH264 is non-EME, and we've talked about moving
> things like VC1 decoding (and encoding once we do that) into a GMP process
> for security reasons, especially for interactive use.

We can decode VC1?

The existing GMPVideoDecoder/MediaDataDecoder still has a GMPCrashHelper. Nothing I'm doing here has any effect on decoding video via GMP. WebAudio is for audio, right?
Flags: needinfo?(cpearce)
Comment on attachment 8870197 [details]
Bug 1366907 - Remove BufferDecoder's GMPCrashHelper.

https://reviewboard.mozilla.org/r/141648/#review145464

(In reply to Chris Pearce (:cpearce) from comment #5)
> WebAudio is for audio, right?

Correct (though I haven't actually checked what happens if there is video muxed with the audio).

::: commit-message-4c7ee:3
(Diff revision 1)
> +Bug 1366907 - Remove BufferDecoder's GMPCrashHelper. r?karlt
> +
> +We no longer support decoding non-EME content via GMPs, so it's not possible

Sounds like there may still be GMP decoding of some non-EME "content", but not audio.

If appropriate please be specific, with for example s/content/audio/.
Attachment #8870197 - Flags: review?(karlt) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53561331ff27
Remove BufferDecoder's GMPCrashHelper. r=karlt
https://hg.mozilla.org/mozilla-central/rev/53561331ff27
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.