[TestGroup UI] Migrate code into the main Treeherder repo

ASSIGNED
Assigned to

Status

Tree Management
Treeherder: Test-based View
P1
normal
ASSIGNED
7 months ago
3 days ago

People

(Reporter: camd, Assigned: camd)

Tracking

(Depends on: 1 bug)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
The code is currently in: https://github.com/mozilla-rpweb/treeherder-manifest.  

One change that perhaps should happen first is that the above-mentioned repo is using Neutrino 5.0, whereas Treeherder is on 4.x.  I'll investigate if we should upgrade Neutrino in Treeherder before merging them.

The Neutrino upgrade guide is here: https://neutrino.js.org/upgrading-neutrino.html
(Assignee)

Updated

7 months ago
Blocks: 1337488
(Assignee)

Updated

7 months ago
Assignee: nobody → cdawson
I think we can just copy the files in and drop history, since there are only 20 commits and most don't have multi-line commit messages:
https://github.com/mozilla-rpweb/treeherder-manifest/commits/master
(Assignee)

Updated

3 months ago
Depends on: 1364894
(Assignee)

Updated

3 months ago
Component: Treeherder → Treeherder: Test-based View
Depends on: 1364891
Depends on: 1403540
Here's the experiment of merging the test based view into the Treeherder repo (but with still using Neutrino v4, to see if it was possible/easier in the meantime) that we discussed earlier:
https://github.com/mozilla/treeherder/compare/test-view-merge-poc

The error that resulted was:
https://emorley.pastebin.mozilla.org/9068433
I tracked down the error to https://github.com/babel/babel/issues/4759 and have updated that branch with a workaround / fixed a problem with the HTML template.

As such, that branch now appears to work :-)
(Assignee)

Comment 4

2 months ago
Wow, awesome!  Nice work!

Perhaps the next step is to get the package versions in alignment so that the TH UI doesn't choke on the update to Bootstrap, etc.  I can work on that.  Awesome, awesome!  :)
(Assignee)

Updated

2 months ago
Depends on: 1408100
No longer depends on: 1403540
Depends on: 1418379
(Assignee)

Updated

18 days ago
Priority: -- → P1
Created attachment 8932989 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3001
(Assignee)

Comment 6

10 days ago
Comment on attachment 8932989 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3001

Not sure when you'll be in to do reviews.  But here ya go.  :)
Attachment #8932989 - Flags: review?(emorley)
(Assignee)

Updated

10 days ago
Status: NEW → ASSIGNED
Comment on attachment 8932989 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3001

Few tweaks and this should be good to go :-)
Attachment #8932989 - Flags: review?(emorley) → review-
(Assignee)

Comment 8

9 days ago
Comment on attachment 8932989 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3001

This has been duly tweaked...  :)
Attachment #8932989 - Flags: review- → review?(emorley)
Comment on attachment 8932989 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3001

Left some comments and a diff of changes that will make the tests pass. Very close now! :-)
Attachment #8932989 - Flags: review?(emorley) → review-
(Assignee)

Comment 10

3 days ago
Comment on attachment 8932989 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3001

Perhaps we can discuss this approach at the all-hands if it's not quite what you were looking for.
Attachment #8932989 - Flags: review- → review?(emorley)
You need to log in before you can comment on or make changes to this bug.